Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented remesher: behavior at zero densities #239

Open
ThomasCeulemans opened this issue Nov 15, 2023 · 0 comments
Open

Implemented remesher: behavior at zero densities #239

ThomasCeulemans opened this issue Nov 15, 2023 · 0 comments
Assignees
@ThomasCeulemans
Labels
enhancement New feature or request

Comments

@ThomasCeulemans
Copy link
Collaborator

Due to some implementation error, the remeshing algorithm fails to accept zero density regions as decently remeshed.
The offending line (in mesher.py::get_recursive_remesh line 779):
if (maxval-minval)<threshold*(minval+maxval):
I would need to check whether just replacing the less than sign with less or equal does not break anything else.
@ThomasCeulemans ThomasCeulemans added the enhancement New feature or request label Nov 15, 2023
@ThomasCeulemans ThomasCeulemans self-assigned this Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasCeulemans ThomasCeulemans

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ThomasCeulemans