Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner boundary: implement #279

Closed
ThomasCeulemans opened this issue Dec 3, 2024 · 0 comments · Fixed by #280
Closed

Inner boundary: implement #279

ThomasCeulemans opened this issue Dec 3, 2024 · 0 comments · Fixed by #280
Labels
bug Something isn't working enhancement New feature or request

Comments

@ThomasCeulemans
Copy link
Collaborator

Currently, we are treating all boundary points equally with our ray-tracer. (stop if ray tracing direction is in same direction of position with respect to model center). However, the inner boundary points are not guaranteed to lie around the center, and should always be te end of a ray. Therefore, I'll need to implement simple datafield to denote whether a boundary point is an inner boundary point or not.

@ThomasCeulemans ThomasCeulemans added bug Something isn't working enhancement New feature or request labels Dec 3, 2024
@ThomasCeulemans ThomasCeulemans linked a pull request Dec 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant