fix precompile by removing src attr from plot constructor #245
Conversation
| function Makie.MakieCore._create_plot!(F, attributes::Dict, ax::GeoAxis, args...) | ||
| source = pop!(attributes, :source, nothing) | ||
| dest = pop!(attributes, :dest, nothing) | ||
| plot = Plot{Makie.default_plot_func(F, args)}(args, attributes) | ||
| isnothing(source) || (plot.kw[:source] = source) | ||
| isnothing(dest) || (plot.kw[:dest] = dest) | ||
| Makie.plot!(ax, plot) | ||
| return plot | ||
| end | ||
|
|
There was a problem hiding this comment.
Perfect, thanks!! I wasn't sure exactly where to inject this but this looks great.
|
Will test this locally then merge. |
|
It looks like this doesn't address I guess you can't dispatch on |
|
You can't currently do |
|
|
asinghvi17
force-pushed
the
sd/fix-precompile
branch
from
9eb0aea
to
c8e6f77
Compare
|
Ugh, I don't understand this - Github is somehow deleting the logs of the actions. |
|
CI ran on the last commit, now to find which example was killing it... |
Decrease the number of examples to try and get the docs to build remove more examples -- what is going on? Revert "remove more examples -- what is going on?" This reverts commit f584cca. Inform when we are doing something refactor geomakiedocumenterblocks to be really generic
comment out certain examples clean up
Comment out more commits
* Use OhMyCards * Add more examples * Fix CI * Fix the make script * Remove GeoMakieDocumenterBlocks * Expand all examples first * fix expandfirst * Add more examples back * Don't build `multiple_crs`
asinghvi17
force-pushed
the
sd/fix-precompile
branch
from
f4e5fbe
to
3fa86e5
Compare
No description provided.