diff --git a/ReferenceTests/src/tests/examples2d.jl b/ReferenceTests/src/tests/examples2d.jl index 8cc85e7e075..735be7bb507 100644 --- a/ReferenceTests/src/tests/examples2d.jl +++ b/ReferenceTests/src/tests/examples2d.jl @@ -1354,7 +1354,7 @@ function ppu_test_plot(resolution, px_per_unit, scalefactor) fig, ax, pl = scatter(1:4, markersize=100, color=1:4, figure=(; size=resolution), axis=(; titlesize=50, title="ppu: $px_per_unit, sf: $scalefactor")) DataInspector(ax) hidedecorations!(ax) - return fig + fig end @reference_test "px_per_unit and scalefactor" begin @@ -1373,3 +1373,10 @@ end st end end + +@reference_test "spurious minor tick (#3487)" begin + fig = Figure(size=(227, 170)) + ax = Axis(fig[1, 1]; yticks = 0:.2:1, yminorticksvisible = true) + ylims!(ax, 0, 1) + fig +end diff --git a/src/makielayout/lineaxis.jl b/src/makielayout/lineaxis.jl index 7d585eb2698..4306f96b5a3 100644 --- a/src/makielayout/lineaxis.jl +++ b/src/makielayout/lineaxis.jl @@ -189,7 +189,7 @@ end # if labels are given manually, it's possible that some of them are outside the displayed limits # we only check approximately because otherwise because of floating point errors, ticks can be dismissed sometimes -is_valid_tick(tv, limits) = (limits[1] <= tv || limits[1] ≈ tv) && (tv <= limits[2] || tv ≈ limits[2]) +is_valid_tick(tv, limits) = (limits[1] ≤ tv || limits[1] ≈ tv) && (tv ≤ limits[2] || tv ≈ limits[2]) function update_tickpos_string(closure_args, tickvalues_labels_unfiltered, reversed::Bool, scale)