Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram is now missing the inspector_label attribute #4440

Open
Sagnac opened this issue Oct 2, 2024 · 2 comments
Open

Histogram is now missing the inspector_label attribute #4440

Sagnac opened this issue Oct 2, 2024 · 2 comments
Labels
Attributes Plot, Block and Scene Attributes bug DataInspector Makie Backend independent issues (Makie core) plot Related to plot object regression This issue describes a regression from a previous version or commit.

Comments

@Sagnac
Copy link
Contributor

Sagnac commented Oct 2, 2024

Makie v0.21.12

julia> using GLMakie # v0.10.12

julia> hist(rand(15); inspector_label = (_, _, _) -> "label")
ERROR: Invalid attribute inspector_label for plot type Plot{Makie.hist, Tuple{Vector{Float64}}}.
julia> :inspector_label in Makie.attribute_names(Hist)
false

julia> :inspector_label in Makie.attribute_names(Image)
true

I remember being able to use a custom inspector_label function with histograms using GLMakie v0.9.6

@Sagnac Sagnac added the bug label Oct 2, 2024
@asinghvi17
Copy link
Member

It looks like that recipe doesn't have generic mixins, maybe we should add those. I'm not sure how you propagate the inspector functions down a plot tree though, @ffreyer?

@asinghvi17 asinghvi17 added the regression This issue describes a regression from a previous version or commit. label Oct 2, 2024
@ffreyer
Copy link
Collaborator

ffreyer commented Oct 3, 2024

It shouldn't doesn't need to be passed down. DataInspector should stop looking at the top level plot that defines these attributes

@ffreyer ffreyer added Makie Backend independent issues (Makie core) plot Related to plot object Attributes Plot, Block and Scene Attributes DataInspector labels Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Attributes Plot, Block and Scene Attributes bug DataInspector Makie Backend independent issues (Makie core) plot Related to plot object regression This issue describes a regression from a previous version or commit.
Projects
None yet
Development

No branches or pull requests

3 participants