Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try temporary fix for WGLMakie CI #4523

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Try temporary fix for WGLMakie CI #4523

wants to merge 1 commit into from

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Oct 24, 2024

Our WGLMakie CI runs have gotten very slow since yesterday and as far as I can tell only LoggingExtras has been changed since then. It's probably not the root cause (maybe that's the same as the texture size failures), but if it reduces the CI runtime from 90min+ back down to 40min this might be a good bandaid fix for now

@ffreyer ffreyer added the skip-changelog Skips changelog enforcer label Oct 24, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Oct 24, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 6.33s (6.22, 6.66) 0.13+- 164.03ms (157.91, 189.11) 8.50+- 477.64ms (462.92, 531.28) 16.42+- 7.08ms (6.84, 8.95) 0.45+- 25.80ms (25.41, 26.86) 0.44+-
master 6.34s (6.21, 6.78) 0.17+- 164.73ms (157.36, 181.33) 7.36+- 476.65ms (462.75, 509.56) 14.54+- 7.03ms (6.81, 7.59) 0.24+- 25.76ms (25.42, 26.78) 0.45+-
evaluation 1.00x invariant, -0.01s (-0.08d, 0.81p, 0.15std) 1.00x invariant, -0.7ms (-0.09d, 0.78p, 7.93std) 1.00x invariant, 0.99ms (0.06d, 0.84p, 15.48std) 0.99x invariant, 0.05ms (0.14d, 0.66p, 0.35std) 1.00x invariant, 0.03ms (0.07d, 0.83p, 0.45std)
CairoMakie 6.06s (5.97, 6.25) 0.08+- 165.06ms (159.86, 177.11) 4.36+- 200.68ms (196.17, 210.09) 3.90+- 6.88ms (6.80, 7.05) 0.07+- 1.06ms (1.03, 1.08) 0.01+-
master 6.02s (5.90, 6.15) 0.08+- 163.49ms (160.04, 172.48) 3.54+- 199.30ms (195.27, 208.93) 3.35+- 6.80ms (6.67, 6.96) 0.08+- 1.07ms (1.05, 1.17) 0.02+-
evaluation 0.99x invariant, 0.05s (0.60d, 0.07p, 0.08std) 0.99x invariant, 1.57ms (0.40d, 0.22p, 3.95std) 0.99x invariant, 1.39ms (0.38d, 0.24p, 3.63std) 0.99x slower X, 0.08ms (1.02d, 0.00p, 0.08std) 1.02x faster ✓, -0.02ms (-0.85d, 0.01p, 0.02std)
WGLMakie 7.07s (6.97, 7.20) 0.06+- 187.56ms (174.61, 207.67) 8.09+- 6.04s (5.93, 6.19) 0.07+- 11.45ms (11.16, 11.90) 0.19+- 149.54ms (147.16, 154.96) 1.76+-
master 7.05s (6.98, 7.14) 0.05+- 186.93ms (176.83, 200.18) 6.67+- 6.43s (6.23, 6.63) 0.09+- 11.53ms (10.87, 12.50) 0.36+- 149.27ms (147.49, 151.91) 1.28+-
evaluation 1.00x invariant, 0.02s (0.40d, 0.21p, 0.06std) 1.00x invariant, 0.63ms (0.09d, 0.79p, 7.38std) 1.06x faster✅, -0.39s (-4.73d, 0.00p, 0.08std) 1.01x invariant, -0.08ms (-0.26d, 0.41p, 0.28std) 1.00x invariant, 0.28ms (0.18d, 0.57p, 1.52std)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Work in progress
Development

Successfully merging this pull request may close these issues.

2 participants