Add compat for FilePaths 0.9 #4863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs davidanthoff/Electron.jl#141 for WGLMakie tests. Compat entry to https://github.com/MakieOrg/Makie.jl/blob/master/WGLMakie/test/Project.toml would be needed as well, otherwise Electron v1.1.0 gets installed, latest is v6.0.0. |
|
Since there is no context in those PRs, is FilePaths@0.9 fixing the load time problems completely? |
|
I do not know the WGLMakie workflow that exhibits recompilations. I can test if instructed. Something with Electron? |
|
The benchmarks should actually catch it - which don't run for outside contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4842
Add compat for FilePaths 0.9