-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.Net Core support #26
Comments
Hello @Ponant ! Thanks ! |
@mickaelpois , that is great, finally! Move directly to .Net Core 1.1 and prepared for 1.2 coming up during spring 2017 or so. Also check out if it needs a singleton, transient or scoped service in Startup. Cheers |
Hi, I will code a .NET Core web application in october, using MangoPay, do you think you'll have the .Net Core API ready for this timeline ? Thank you |
Well... You deleted your post concerning a planning of this evolution since I posted mine. Does it means it's not scheduled anymore ? Please at least answer me, I need to know wich payment provider I have to choose. Thanx |
Good afternoon @NicolasPerego, I can't remember if there was a previous comment about .NET Core support, and if it was deleted. This project was on hold, but have been recently relaunched! We hope that we could give a .NET Core support in the next couple of months. We will provide you every updates about this project on this feed. Have a nice day, Mickaël |
Great news ! Thanx a lot |
Hey, quick update on this: we've taken the time to look into the what would be required, and contary to what we originally thought, the changes required are quite significant, and non-compatible with the existing SDK, which would mean running two different .NET SDKs in parellel which is not something we're currently keen to do at this time I'm afraid. |
Hi hobailey. I must say I'm disappointed by the news. .NET Core is released for more than a year now, and I'm suprised you're only discovering now it's not compatible with your actual SDK. Your .NET dev team should maybe do more technological watch if they dont want to be outdated by the tech they master. Anyway, you should know that most of new .NET web app will use .NET Core, and you're probably will missing some buisness here, as your competitors have already released .NET Core SDKs (for months). Sorry for the rant, I was really hopping to use MangoPay, and I'm really disappointed. |
Hi @hobailey @mickaelpois, I had a second look at your API today, and with the recent release of .neststandard 2.0, and some new releases of your dependencies, it took me about 30mn to make your API to .NET Core compliant. No optimization, no usage of async, only creating a new library project netstandard, and adding the right dependencies. Only 2 tests are not ok, but if I understand correctly the errors, they're a not technical problems. Sorry for not sharing it here, but I'm not familiar with git and I don't have any time to learn it now. I forked and modified the project, or contact me if you want me to send you the project. |
I managed to make a full asynchronous API for ASP.NET Core 2.0 from this base (not a fork, a new project). You can find it there : https://github.com/NicolasPerego/mangopay-net.core-sdk. I hope it will help you, or other users. |
Hi @NicolasPerego, A big thanks to you for your work, as it seems to be very valuable ! Mickaël |
Thank you for having a look at my work @mickaelpois. I don't see any easy way to maintain it, but to adapt each new fonctionnality to the new .NET Core project... :/ I'm still struggling with the logging system, which wasn't appearing as a problem in the tests. I can't find a way to make the "Common.Logging.Log4Net208" package works as logger with "Common.Logging" or "Common.Logging.Core" packages. Since you probably have a better understanding of this Logging system than me, if you guys have some time to have a look at this, please do, I have to move on to other devs on my project for now. Edit : |
OK, I found the problem with Common.Logging/log4net, it has nothing to do with the MangoPay SDK. It comes from log4net, they did not made adjustment since the netstandard 2.0 is out (see my last comment in apache/logging-log4net#14). I made a log4net.dll with a slight adjustment, and it works perfectly with Common.Logging and the SDK. Let's hope log4net will correct this. Edit : they probably will in the next release which will be compliant with netstandard 2.0 (https://issues.apache.org/jira/browse/LOG4NET-572?focusedCommentId=16338184&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16338184) |
Any news about .net core support? |
Any plan to support it soon ? |
Hi. This SDK is now the only dependancy we are waiting for to support netstandard2.0 |
Is there an update on this? In 2019 this is a very huge blocker considering that .NET is strongly moving to .NET Core now. If this is just waiting for code review for over a year now, maybe you should just develop this in the open (i.e. open a pull request) and have the community help with the review. |
@poke If you're in a hurry and can't wait for an official release, I'm using in production for about 1 year the Core 2.0 compliant (fully async) code I adapted from here, without any trouble. I try to update it when there's a new release. Only glitch was about log4net compatibility, and I modified their code to make it work long time ago, but I guess you can use other loggers (not tried), or tell me if you need the dll. |
@NicolasPerego Thanks for the offer! Right now, I am evaluating Mangopay and its API, so having access to an officially supported SDK library is somewhat important. Depending on our requirements, I maybe would rather use the APIs in a direct way than having to rely on a third-party library for payment-related things. I will keep your library in mind though, so thanks again for the offer! That being said: Official .NET Core support being in the works for over 2 years is not the best sign. |
@poke I perfectly understand, it's a sensitive area. Feel free to inspire your implementation with my project, you'll see I almost added nothing (only an option to not log the KYC files). Honestly, the Mangopay API is very well done and easy to use, the only problem for me was the big delay to deliver .NET Core release. |
@mickaelpois This issue has been open for nearly three years. We have had to make the unfortunate decision to change payment provider purely for the reason Mangopay doesn't seem to show any interest in official support for netstandard any time soon. It's a shame, but people can't wait forever and three years is nearly forever for the .Net ecosystem. |
I think this issue could be easily fixed by moving to .Net Standard 1.1 since Net 4.5 and Net Core 1.0 would be supported! That also would mean just one code base and a future proof SDK! I have created Issue #67 targeting this proposal. |
Any updates on this? My company is also reviewing escrow payment providers, but the fact that you have spent 3 years without providing an official .net core/standard solution is very concerning. From a business perspective we think: If this is such a complex task for you, how would you cope with other urgent business requirements? |
Today I published this: https://github.com/JuanGarciaCarmona/mangopay-net-core-sdk |
This is actually done by the MangoPaySDK as well. |
Hi,
Is it possible to have .Net Core support for ASP.NET Core?
The text was updated successfully, but these errors were encountered: