-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert typehints within docstrings to proper in-code typings #2121
Comments
@Darylgolden I would like to work on this issue. |
Go ahead! |
Hi @Darylgolden Can I get a list of all the files which have to be changed? |
I would like to work on this issue |
Hi @dhgoratela, unfortunately we don't have such a list. You can probably find many instances just looking through the files. |
Did a quick run through of |
Le me do that. Thanks @Davidy22 for the info! |
Okay shall check that for more understanding |
I think this issue can be closed right? |
All the parameters are gone, but there are still return types and attribute types in docstrings. The problem with return types is that the documentation doesn't seem to pick up on the return type hint, so I don't want to convert everything at the cost of ruining the docs. The attribute types are doable I think. |
I want to work on this. If it is not already done (new to opensource) |
I think it might be more worth it to work on #3375 |
Enhancement proposal
Currently, there are many instances of type hints being provided within docstrings - at Paragraph, for example. This has the disadvantage of not being able to be read by IDEs. Since we've standardized all new PRs to use in-code typings since a while back, the old ones should also be changed. A good example of properly implemented typings can be found here, for instance.
This is far too broad an issue to be resolved by a single PR, so I recommend fixing around one file per PR.
Additional comments
The text was updated successfully, but these errors were encountered: