Skip to content

Commit 9739478

Browse files
committed
MDEV-35818: Fix replace_binlog_file info message
`ATTRIBUITE_FORMAT` from #3360 uncovers issues on `my_snprintf` uses. This commit fixes the one in `Binlog_commit_by_rotate::` `replace_binlog_file()` about “required size too big”. All I found is that it’s not present in 11.4 (after I prepared previous batches for all maintained branches), for GitHub blame can’t process a file with over 10K lines.
1 parent 3e9da8c commit 9739478

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

sql/log.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13257,10 +13257,11 @@ bool Binlog_commit_by_rotate::replace_binlog_file()
1325713257
DBUG_EXECUTE_IF("simulate_required_size_too_big", required_size= 10000;);
1325813258
if (required_size > m_cache_data->file_reserved_bytes())
1325913259
{
13260-
sql_print_information("Could not rename binlog cache to binlog(as "
13260+
sql_print_information("Could not rename binlog cache to binlog (as "
1326113261
"requested by --binlog-commit-by-rotate-threshold). "
13262-
"Required %llu bytes but only %llu bytes reserved.",
13263-
required_size, m_cache_data->file_reserved_bytes());
13262+
"Required %zu bytes but only %lu bytes reserved.",
13263+
required_size, static_cast<unsigned long>(
13264+
m_cache_data->file_reserved_bytes()));
1326413265
return false;
1326513266
}
1326613267

0 commit comments

Comments
 (0)