Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

labs/05 - Incomplete and does not match source code #2

Open
jhogan05 opened this issue Dec 18, 2024 · 0 comments
Open

labs/05 - Incomplete and does not match source code #2

jhogan05 opened this issue Dec 18, 2024 · 0 comments

Comments

@jhogan05
Copy link

Readme.md incomplete (absent Source snippets x 3) at the end, and
no discussion on Controller folder / StateController.cs which is found in the source

Source code does not match Source code (lab/05..) displayed in Readme.md snippets:

  • ISessionManager.cs -- GetSessionAync() vs GetSession() [ Client and Server projects]
  • SessionManger.cs -- GetSessionAync() vs GetSession() / UpdateSessionAsync() vs UpdateSession [Client and Server projects]
  • SessionIdManager.cs -- GetSessionIdAsync() vs GetSessionAsync()
  • SessionManager.cs (Server) in Source code:
    • more modern constructor with dependency injection of SessionIdManger
    • in GetSessionAsync extra code from "var endtime... with the "while (session.IsCheckedOut)..{ }" loop in Readme.md
    • in UpdateSessionAsync extra code: "_session[key].IsCheckedOut = false;" in Readme.md
    • in Replace() code to shortcut if newSession / oldSession are the same (not in Readme.md)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant