Skip to content

Commit 2cbdfc5

Browse files
authored
Revert "Use Windows VM until Azure ACI outage is resolved (jenkins-infra#898)" (jenkins-infra#900)
Windows virtual machines are configured with Java 11 by default, though they have Java 17 and Java 21 installed. This change does not propagate the Java version configuration to the Windows virtual machine. Jobs that are configured to use Java 17 on Windows or Java 21 on Windows are mistakenly using Java 11 on Windows. Reverting the change so that a complete fix can be tested and confirmed working before a pull request is proposed. This reverts commit bcd195f.
1 parent bcd195f commit 2cbdfc5

File tree

2 files changed

+1
-10
lines changed

2 files changed

+1
-10
lines changed

test/groovy/BuildPluginStepTests.groovy

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -144,12 +144,7 @@ class BuildPluginStepTests extends BaseTest {
144144
// then it runs a stage in a linux container by default
145145
assertTrue(assertMethodCallContainsPattern('node', 'maven'))
146146
// then it runs a stage in a Windows container by default
147-
// TODO: Restore this assertion when ACI outage is resolved
148-
// https://github.com/jenkins-infra/helpdesk/issues/4490
149-
// assertTrue(assertMethodCallContainsPattern('node', 'maven-windows'))
150-
// TODO: Delete this assertion when ACI outage is resolved
151-
// https://github.com/jenkins-infra/helpdesk/issues/4490
152-
assertTrue(assertMethodCallContainsPattern('node', 'docker-windows'))
147+
assertTrue(assertMethodCallContainsPattern('node', 'maven-windows'))
153148
assertJobStatusSuccess()
154149
}
155150

vars/buildPlugin.groovy

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,6 @@ def call(Map params = [:]) {
4343
def agentContainerLabel = jdk == '8' ? 'maven' : 'maven-' + jdk
4444
if (platform == 'windows') {
4545
agentContainerLabel += '-windows'
46-
// TODO: Remove when Azure Container (ACI) outage is resolved
47-
// https://github.com/jenkins-infra/helpdesk/issues/4490
48-
echo "Using Windows virtual machines during Azure ACI outage https://status.jenkins.io/issues/2025-01-08-ci.jenkins.io-azure-outage/"
49-
agentContainerLabel = 'docker-windows'
5046
}
5147
label = agentContainerLabel
5248
}

0 commit comments

Comments
 (0)