-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Lighthouse #1832
Labels
Comments
@allcontributors please add @eldaduzman for ideas |
I've put up a pull request to add @eldaduzman! 🎉 |
Can we close this one because persistent context keyword exists? |
@leeuwe Do you think we could move that issue as feature request to browser extensions repository? |
Sure! |
closed in favour of MarketSquare/robotframework-browser-extensions#15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Google lighthouse is an awesome client side performance and accessibility testing tool.
It has a good integration with playwright using an nmp package.
It can be very easily used by rf-browser with JS extension,
For example:
js-extensions/rfbrowser-lighthouse.js:
test.robot:
The problem is when you need to authenticate.
Lighthouse opens a new browser context and this means that all authentication fields are gone.
Describe the solution you'd like
One option is to use Persistent Context with playwrights launchPersistentContext function.
This can take a directory for storage and other properties and then when lighthouse is activated it keeps the context.
So I guess adding a
new persistent context
keyword which takes a path as first input and all the other context arguments next would solve this problem.Describe alternatives you've considered
Maybe it is possible to explicitly support executing lighthouse from rf-browser using a designated keyword, however this might not be flexible enough, + it could require too much maintenance efforts.
Additional context
I've tried to create a persistent context with a js extention:
But it's not being stored on rf-browsers cache so it doesn't solve the problem.
The text was updated successfully, but these errors were encountered: