From b8e493b9a4edd3ae25b501b066726ec11339f60d Mon Sep 17 00:00:00 2001 From: Mathieu Velten Date: Sat, 20 Oct 2018 18:31:24 +0200 Subject: [PATCH] Add Hound checks Fix flake8 problems --- .hound.yml | 2 ++ .travis.yml | 6 +++--- pynetgear/__init__.py | 7 ++++--- pynetgear/__main__.py | 1 + setup.cfg | 3 +++ 5 files changed, 13 insertions(+), 6 deletions(-) create mode 100644 .hound.yml diff --git a/.hound.yml b/.hound.yml new file mode 100644 index 0000000..79c6e75 --- /dev/null +++ b/.hound.yml @@ -0,0 +1,2 @@ +flake8: + enabled: true diff --git a/.travis.yml b/.travis.yml index 0565303..f8169ae 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,9 +1,9 @@ language: python python: - - '3.4' + - '3.3' - '2.7' before_install: - - pip install pep8 + - pip install flake8 script: - - find . -name \*.py -exec pep8 --max-line-length=120 {} + + - find pynetgear -name \*.py -exec flake8 --max-line-length=120 {} + diff --git a/pynetgear/__init__.py b/pynetgear/__init__.py index 182f305..d905bf0 100644 --- a/pynetgear/__init__.py +++ b/pynetgear/__init__.py @@ -351,7 +351,7 @@ def autodetect_url(): verify=False) if r.status_code == 200: return url - except: + except requests.exceptions.RequestException: pass return None @@ -397,8 +397,8 @@ def _get_soap_headers(service, method): def _is_valid_response(resp): return (resp.status_code == 200 and - ("0000" in resp.text or - "000" in resp.text)) + ("0000" in resp.text or + "000" in resp.text)) def _is_unauthorized_response(resp): @@ -414,6 +414,7 @@ def _convert(value, to_type, default=None): # If value could not be converted return default + SERVICE_PREFIX = "urn:NETGEAR-ROUTER:service:" SERVICE_DEVICE_INFO = "DeviceInfo:1" SERVICE_DEVICE_CONFIG = "DeviceConfig:1" diff --git a/pynetgear/__main__.py b/pynetgear/__main__.py index f83e5b6..ec49eeb 100644 --- a/pynetgear/__main__.py +++ b/pynetgear/__main__.py @@ -18,5 +18,6 @@ def main(): for i in devices: print(i) + if __name__ == '__main__': main() diff --git a/setup.cfg b/setup.cfg index b88034e..e91ee50 100644 --- a/setup.cfg +++ b/setup.cfg @@ -1,2 +1,5 @@ [metadata] description-file = README.md + +[flake8] +max-line-length = 120