-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Format of 'lattice_vectors' is unclear for 2D, 1D and 0D systems #196
Comments
Do you think it is OK to merely suggest I was a somewhat strong proponent for standardizing on reduced coordinates. Hence, I will certainly provide an |
Non- |
No issue as far as I know. I've only planned it as a database-specific property. Unless multiple databases chime in an say it is very useful for them, we can standardize it next meeting. |
I'd suggest either to:
What do you think? |
I say, 2, but not so much discourage non- But if someone wants to do 1, I'll be happy to merge that PR. |
I have opened PR #206. |
Specification defines
lattice_vectors
as three lattice vectors in Cartesian coordinates. However, it is not clear how the vectors are defined for nonperiodic dimensions. Currently it seems that such vectors are ignored, and as such can contain any values. But it would probably make sense to have a default, and I would suggest havingnull
s for all the coordinates of vectors in nonperiodic dimensions.An example of a 2D surface on XZ plane:
The text was updated successfully, but these errors were encountered: