Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for OPTIMADE v1.2.x #1419

Open
ml-evs opened this issue Dec 6, 2022 · 0 comments
Open

Support for OPTIMADE v1.2.x #1419

ml-evs opened this issue Dec 6, 2022 · 0 comments
Labels
help wanted Extra attention is needed OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 schema Concerns the schema models
Milestone

Comments

@ml-evs
Copy link
Member

ml-evs commented Dec 6, 2022

This issue is for tracking our support with the upcoming release candidates of OPTIMADE v1.2. There are several issues/PRs tagged under the OPTIMADE v1.2 label
and milestone.

We should collect all the PRs in a separate branch for v1.2 features before merging them into master. This will allow us to create the v1.2 OpenAPI schemas for the specification release (without necessarily having all PRs finished, fully-tested and released).

As all of the functionality in 1.2 is both optional and backwards compatible with 1.1, I don't think we necessarily need to go down the namespace package route and maintain support for older 1.1 models/servers, though it may be useful to begin thinking about it for future versions (especially the client and the validator, which could be pointed at older versions of the models for deserializing the response from other implementations). This would require an overhaul of our CI that I don't think we really have the resources to do at the moment; instead it may be easier to patch the validator/client to work differently depending on the API version returned by the implementation.

@ml-evs ml-evs added the OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 label Dec 6, 2022
@ml-evs ml-evs added this to the OPTIMADE v1.2 milestone Dec 6, 2022
@ml-evs ml-evs added the schema Concerns the schema models label Dec 6, 2022
@ml-evs ml-evs added the help wanted Extra attention is needed label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 schema Concerns the schema models
Projects
None yet
Development

No branches or pull requests

1 participant