Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update_openapijson invoke task is not idempotent #1429

Open
ml-evs opened this issue Dec 6, 2022 · 0 comments
Open

update_openapijson invoke task is not idempotent #1429

ml-evs opened this issue Dec 6, 2022 · 0 comments
Assignees
Labels
bug Something isn't working CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action)

Comments

@ml-evs
Copy link
Member

ml-evs commented Dec 6, 2022

Just realised this is what is causing it, after many confused commits where they get reordered again.

For some reason, the release deployment is reordering the "x-optimade-" fields in the OpenAPI schema, see: 5243791

I assume this is caused by some dependency version differences between the CI and local setups, since the CI diff only uses JSON diff to check differences (which is invariant to field ordering -- we could make it not so).

EDIT: I actually get the same behaviour locally after multiple re-runs of invoke update-openapijson. We should somehow fix the ordering here...

@ml-evs ml-evs added bug Something isn't working CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) labels Dec 6, 2022
@ml-evs ml-evs self-assigned this Dec 6, 2022
@ml-evs ml-evs changed the title CI master deployment reorders fields in the OpenAPI schema update_openapijson invoke task is not idempotent Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action)
Projects
None yet
Development

No branches or pull requests

1 participant