Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for enhanced list comparisons #1467

Open
ml-evs opened this issue Jan 9, 2023 · 1 comment
Open

Support for enhanced list comparisons #1467

ml-evs opened this issue Jan 9, 2023 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed transformers Related to all filter transformers

Comments

@ml-evs
Copy link
Member

ml-evs commented Jan 9, 2023

At some point we should try to support the grammar constructs listed in comparisons of list properties, e.g., list HAS ANY < 3, > 2.

One such correlated list query will come up in the CCPNC-DB implementation (tagging @jkshenton), where the following case might occur: if you have a flat list of chemical shifts of all species in a simulation, you will want to be able to do:

species_at_sites HAS Si:_ccpncdb_chemical_shifts HAS <= 3, >= 2

to request all Si chemical shifts between 2 and 3 inclusive. Of course it would be easier to keep the shifts in a dictionary keyed by element, at which case the query would be simplified to

_ccpnc_chemical_shifts.Si HAS <=3, >=2

but it would be great if we could support both.

@ml-evs ml-evs added enhancement New feature or request help wanted Extra attention is needed transformers Related to all filter transformers labels Jan 9, 2023
@jkshenton
Copy link

Thanks @ml-evs! Yes, supporting that sort of query would be essential for the CCPNC-DB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed transformers Related to all filter transformers
Projects
None yet
Development

No branches or pull requests

2 participants