Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation Metadata fields #1697

Open
3 tasks done
JPBergsma opened this issue Jul 5, 2023 · 0 comments
Open
3 tasks done

Implementation Metadata fields #1697

JPBergsma opened this issue Jul 5, 2023 · 0 comments
Assignees
@JPBergsma
Labels
enhancement New feature or request ergonomics Features that improve the usability of the package help wanted Extra attention is needed models For issues related to the pydantic models directly OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2
Milestone
OPTIMADE v1.2

Comments

@JPBergsma
Copy link
Contributor

JPBergsma commented Jul 5, 2023 •
edited
Loading

Recently, PR#463 has been merged with the OPTIMADE Specification.
I have therefore created this issue to keep track of the adoption of this PR in the optimade python tools.
One question I still have is whether we should return the meta field in case the optimade version is less than 1.2. A client that would specifically request version 1.2 would not understand the fields under meta. So I am wondering if we could break older clients. On the other hand, the JSON API specification does mention that there could be fields under meta so in that sense an older client could expect that there are values there.

ToDo

  • : Get a basic metadata field shared.
  • : Add tests for metadata field.
  • : Make sure validator can handle metadata fields.
@JPBergsma JPBergsma added enhancement New feature or request models For issues related to the pydantic models directly ergonomics Features that improve the usability of the package OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2 labels Jul 5, 2023
@JPBergsma JPBergsma self-assigned this Jul 5, 2023
@JPBergsma JPBergsma added this to the OPTIMADE v1.2 milestone Jul 5, 2023
@JPBergsma JPBergsma mentioned this issue Jul 6, 2023
Merged
@ml-evs ml-evs added the help wanted Extra attention is needed label Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JPBergsma JPBergsma

Labels
enhancement New feature or request ergonomics Features that improve the usability of the package help wanted Extra attention is needed models For issues related to the pydantic models directly OPTIMADE v1.2 This label describes actions that have to be taken to be complient with OPTIMADE 1.2
Projects
None yet
Milestone
OPTIMADE v1.2
Development

No branches or pull requests
2 participants
@ml-evs @JPBergsma