From 685199dd4648c748f96b5e1515ba5e89fc4155d7 Mon Sep 17 00:00:00 2001
From: Aryan Jassal <aryan.jassal@matrix.ai>
Date: Tue, 15 Oct 2024 09:53:00 +1100
Subject: [PATCH] chore: addressed review [ci skip]

---
 src/secrets/CommandMkdir.ts | 36 +++++++++++++++++++-----------------
 1 file changed, 19 insertions(+), 17 deletions(-)

diff --git a/src/secrets/CommandMkdir.ts b/src/secrets/CommandMkdir.ts
index e8208a5e..7643f6ca 100644
--- a/src/secrets/CommandMkdir.ts
+++ b/src/secrets/CommandMkdir.ts
@@ -13,7 +13,9 @@ class CommandMkdir extends CommandPolykey {
   constructor(...args: ConstructorParameters<typeof CommandPolykey>) {
     super(...args);
     this.name('mkdir');
-    this.description('Create a Directory within a Vault');
+    this.description(
+      'Create a Directory within a Vault. Empty directories are not a part of the vault and will not be shared when cloning a Vault.',
+    );
     this.argument(
       '<secretPath...>',
       'Path to where the directory to be created, specified as <vaultName>:<directoryPath>',
@@ -62,28 +64,28 @@ class CommandMkdir extends CommandPolykey {
           const writer = response.writable.getWriter();
           let first = true;
           for (const [vault, path] of secretPaths) {
-            await writer.write({
-              nameOrId: vault,
-              dirName: path,
-              metadata: first
-                ? { ...auth, options: { recursive: options.recursive } }
-                : undefined,
-            });
+            if (first) {
+              first = false;
+              await writer.write({
+                nameOrId: vault,
+                dirName: path,
+                metadata: {
+                  ...auth,
+                  options: { recursive: options.recursive },
+                },
+              });
+            } else {
+              await writer.write({ nameOrId: vault, dirName: path });
+            }
           }
           await writer.close();
           return response;
         }, meta);
 
-        // As git does not track empty directories in version control, we need
-        // to inform the user about this.
-        process.stderr.write(
-          'WARNING: Empty directories will not be affected by modifications to the vault state (version change, sharing/cloning, etc.)\n',
-        );
-
-        let shouldError = false;
+        let hasErrored = false;
         for await (const result of response.readable) {
           if (result.type === 'error') {
-            shouldError = true;
+            hasErrored = true;
             let message: string = '';
             switch (result.code) {
               case 'ENOENT':
@@ -102,7 +104,7 @@ class CommandMkdir extends CommandPolykey {
             );
           }
         }
-        if (shouldError) {
+        if (hasErrored) {
           throw new ErrorPolykeyCLIMakeDirectory(
             'Failed to create one or more directories',
           );