Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundling and fixing pkg #25

Closed
tegefaulkes opened this issue Oct 5, 2023 · 3 comments · Fixed by #26
Closed

Bundling and fixing pkg #25

tegefaulkes opened this issue Oct 5, 2023 · 3 comments · Fixed by #26
Assignees
@tegefaulkes
Labels
development Standard development epic Big issue with multiple subissues r&d:polykey:supporting activity Supporting core activity

Comments

@tegefaulkes
Copy link
Contributor

tegefaulkes commented Oct 5, 2023 •
edited
Loading

Specification

This is an epic that tracks the progress of getting the CLI fully working.

I'll add the relevant issues to this epic after reviewing them.

Additional context

Tasks

  1. Use a bundler to combine the source into a single js file.
  2. Check that all artefacts that we need are included and any spurious stuff is left out.
  3. Check that the single js file runs as expected using node.
  4. package the single js file with pkg and ensure it runs properly.
@tegefaulkes tegefaulkes added the development Standard development label Oct 5, 2023
@tegefaulkes tegefaulkes self-assigned this Oct 5, 2023
@tegefaulkes tegefaulkes added the epic Big issue with multiple subissues label Oct 5, 2023
@tegefaulkes
Copy link
Contributor Author

This really consists of two main parts.

  1. Selecting and applying a bundler and getting that working.
  2. getting pkg to work with the bundled code and node20.

What bundler are we going to go with?

@CMCDragonkai
Copy link
Member

#23 and MatrixAI/TypeScript-Demo-Lib#32

  • esbuild

@CMCDragonkai
Copy link
Member

https://github.com/vercel/pkg-fetch/issues/285#issuecomment-1748056724

@tegefaulkes tegefaulkes mentioned this issue Oct 6, 2023
Merged
13 tasks
@CMCDragonkai CMCDragonkai added the r&d:polykey:supporting activity Supporting core activity label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tegefaulkes tegefaulkes

Labels
development Standard development epic Big issue with multiple subissues r&d:polykey:supporting activity Supporting core activity
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bundling and pkg fixes MatrixAI/Polykey-CLI
2 participants
@CMCDragonkai @tegefaulkes