You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At present, its difficult to add light definitions without contributing directly to the project since the validate_item function assumes the PyDMXControl.profiles. module name being present. Perhaps the code could be modified si that if the module is not found you search the broader namespace for the module before failing.
I plan to hopefully contribute to this projects codebase on a few fronts after I get done with my own testing. 😄
In the meantime, I found a work around. If one defines a light in a file called MyLight with a class of MyAwesomeLight, they can add this to their executing class:
Ah yes, that is a very good point, I hadn't really put in any consideration at all for custom fixtures when I wrote the JSON logic. Open to either scanning the wider namespace if the profile isn't found within the library, or open to allowing a way for profiles to be passed in as a second argument with the JSON load, so that we look at in-library plus the ones passed in, rather than scanning the whole wider namespace.
At present, its difficult to add light definitions without contributing directly to the project since the
validate_item
function assumes the PyDMXControl.profiles. module name being present. Perhaps the code could be modified si that if the module is not found you search the broader namespace for the module before failing.I plan to hopefully contribute to this projects codebase on a few fronts after I get done with my own testing. 😄
In the meantime, I found a work around. If one defines a light in a file called
MyLight
with a class ofMyAwesomeLight
, they can add this to their executing class:test.py
light_config.json
The text was updated successfully, but these errors were encountered: