From 7e38b42ddebf5dd71f1f005c7f16a189464e3331 Mon Sep 17 00:00:00 2001
From: Adei Josol <helena.josol@bdi.ox.ac.uk>
Date: Fri, 25 Mar 2022 14:21:30 +0000
Subject: [PATCH] Validate and do not save when checking imported Folder
 associations

---
 .../core/container/FolderService.groovy          | 16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

diff --git a/mdm-core/grails-app/services/uk/ac/ox/softeng/maurodatamapper/core/container/FolderService.groovy b/mdm-core/grails-app/services/uk/ac/ox/softeng/maurodatamapper/core/container/FolderService.groovy
index 64bc475bc0..97d594edc3 100644
--- a/mdm-core/grails-app/services/uk/ac/ox/softeng/maurodatamapper/core/container/FolderService.groovy
+++ b/mdm-core/grails-app/services/uk/ac/ox/softeng/maurodatamapper/core/container/FolderService.groovy
@@ -644,17 +644,11 @@ class FolderService extends ContainerService<Folder> {
     }
 
     void checkImportedFolderAssociations(User importingUser, Folder folder) {
-        // Traverse breadth-first to avoid recursion
-        List<Folder> folders = [folder]
-        for (int i = 0; i < folders.size(); i++) {
-            folders[i].checkPath()
-            folders[i].createdBy = importingUser.emailAddress
-            if (!folders[i].id) save(folders[i], validate: false) // Skip validation to avoid error on null folderId/multiFacetAwareItemId
-            checkFacetsAfterImportingMultiFacetAware(folders[i])
-            folders[i].childFolders?.each {
-                if (!folders.contains(it)) folders << it
-            }
-        }
+        folder.checkPath()
+        folder.createdBy = importingUser.emailAddress
+        folder.validate()
+        checkFacetsAfterImportingMultiFacetAware(folder)
+        folder.childFolders?.each { checkImportedFolderAssociations(importingUser, it) }
         log.debug('Folder associations checked')
     }
 }