Skip to content

Define: add new columns to a specific position #56

Closed
@xitology

Description

@xitology
Member

Currently, Define adds any new columns at the end of the current column list. This is fine as the default behavior, but it should be possible to insert them at the beginning or at any particular position.

Definitions that are replacing existing columns currently retain their positions. It should be possible to re-position them as if they are new columns.

Activity

clarkevans

clarkevans commented on Mar 28, 2024

@clarkevans
Contributor

Databricks "ADD COLUMN" has two options:

FIRST
If specified the column will be added as the first column of the table, or the field will be added as the first field of in the containing struct.
AFTER identifier
If specified the column or field will be added immediately after the field or column identifier.

xitology

xitology commented on Mar 28, 2024

@xitology
MemberAuthor

I'm thinking of the following interface:

  1. @funsql define(x => f()): if x already present, preserve its position, otherwise, add it to the end. This is the current behavior.
  2. @funsql define(x => f(), after = true): add or move x to the end.
  3. @funsql define(x => f(), after = y): add or move x to the next position after field y, an error if y does not exist.
  4. @funsql define(x => f(), before = true): add or move x to the beginning.
  5. @funsql define(x => f(), before = y): add or more x to the position right before y, an error if y does not exist.
  6. before and after cannot be both set.
xitology

xitology commented on Sep 23, 2024

@xitology
MemberAuthor

Added in 2459dd0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @clarkevans@xitology

        Issue actions

          Define: add new columns to a specific position · Issue #56 · MechanicalRabbit/FunSQL.jl