-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement TypedInput for node text fields #21
Comments
I'm not sure how making the exchange name a typed input would solve your problem. What if I allowed the exchange name to be overridden by the node input object? Would that get you what you want? |
Yes, it would be great. Basically, any string node property should be overridable from input, or at least use TypedInput. Thank you! |
@namtab00 I took a look at this and I think I completely misunderstood what you were asking. Fist of all sending message property values won't work here because, in the case of exchange name at least, the value needs to exist on load. So am I correct in assuming you are requesting typedInput for flow, global, and str? And if so I’m pretty sure the node would need to be manually reloaded any time one of the variables changes. Is that acceptable? |
When you're saying that the value needs to exists on load, does that mean on flow load (nodered startup) ? So, in my particular use case, the exchange name for an amqp-out cannot be set dynamically based on handled messages? I understand this requirement for amqp-in, as that node must, on nodered startup, connect to a specific exchange and listen for new messages. But amqp-out IMHO, can wait until it's very execution to derive all of its own properties dynamically (from flow/global/env and even msg) and only then connect to the exchange. |
Hmm. I'm wondering if there may be performance issues tied to declaring the exchange right before every message publish event. |
Could you please implement TypedInput for all text inputs of nodes amqp-in and amqp-out ?
In particular, I'm using amqp-out with a dynamic Exchange Name, but it being a pure text field, the only way possibile to make it dynamic is by using an env variable and setting it with the "universal" env var syntax ${ENV_VAR}, so I have to jump through hoops because really my source value might arrive from various contexts (flow / global)
The text was updated successfully, but these errors were encountered: