From 6041a7b2985db8bf25b255994285c92ed3e7fd9f Mon Sep 17 00:00:00 2001 From: yilong zhang Date: Sat, 21 Dec 2024 05:32:38 +0000 Subject: [PATCH 1/3] avoid using `defaultColDef` to fix the bug for new reactR version --- .github/workflows/pkgdown.yaml | 1 - R/reactable2.R | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/pkgdown.yaml b/.github/workflows/pkgdown.yaml index 63d1ff8..d23f896 100644 --- a/.github/workflows/pkgdown.yaml +++ b/.github/workflows/pkgdown.yaml @@ -32,7 +32,6 @@ jobs: - uses: r-lib/actions/setup-r-dependencies@v2 with: - extra-packages: any::pkgdown, reactR@0.5.0, local::. needs: website - name: Build site diff --git a/R/reactable2.R b/R/reactable2.R index 5a3fb4e..787c0f0 100644 --- a/R/reactable2.R +++ b/R/reactable2.R @@ -97,7 +97,7 @@ reactable2 <- function( filterable = filterable, searchable = searchable, defaultPageSize = defaultPageSize, - defaultColDef = col_def, + #defaultColDef = col_def, showPageSizeOptions = showPageSizeOptions, borderless = borderless, striped = striped, From 090ebcfaf90b06360a2bba35b72d661f2775dacb Mon Sep 17 00:00:00 2001 From: Nan Xiao Date: Sat, 21 Dec 2024 00:48:27 -0500 Subject: [PATCH 2/3] Revert #66 properly --- .github/workflows/pkgdown.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/pkgdown.yaml b/.github/workflows/pkgdown.yaml index d23f896..a7276e8 100644 --- a/.github/workflows/pkgdown.yaml +++ b/.github/workflows/pkgdown.yaml @@ -32,6 +32,7 @@ jobs: - uses: r-lib/actions/setup-r-dependencies@v2 with: + extra-packages: any::pkgdown, local::. needs: website - name: Build site From ad2ba30557cd1f23436d839151124d0a0320bd3e Mon Sep 17 00:00:00 2001 From: Nan Xiao Date: Sat, 21 Dec 2024 00:49:00 -0500 Subject: [PATCH 3/3] Explain why the line is commented out --- R/reactable2.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/reactable2.R b/R/reactable2.R index 787c0f0..a91b39e 100644 --- a/R/reactable2.R +++ b/R/reactable2.R @@ -97,7 +97,7 @@ reactable2 <- function( filterable = filterable, searchable = searchable, defaultPageSize = defaultPageSize, - #defaultColDef = col_def, + # defaultColDef = col_def, # This breaks rendering under reactR >= 0.6.0 showPageSizeOptions = showPageSizeOptions, borderless = borderless, striped = striped,