You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometimes the changes for feature/B depend on the changes for feature/A. The Depends-On: #1234 syntax allows me to block merging feature/B until the PR for feature/A merges, but a small typo can make that fail silently.
It would be nice if there was an obvious user-facing confirmation that Depends-On: was parsed successfully. One option would be to post a comment, like the existing "Mergify rebased successfully" comment. Another option would be an emoji on the PR description, like what is done when commenting "@Mergifyio rebase".
Actual Behavior
depends-on: #1234, depends on: #1234, Depends-On #1234 etc don't create a dependency, but look correct at first glance.
Steps to Reproduce the Problem
Create two PRs
Add Depends-On: #1 to PR #2, but get the syntax wrong
Approve PR #2 and watch it merge automatically
Specifications
Pull Request URL:
Mergify Config URL:
The text was updated successfully, but these errors were encountered:
Those are great suggestions, thank you. I'm not sure how to do this right now:
The emoji reactions are pretty limited. If we could react with 🔗 it could be cool but that's not in the list of allowed reactions. We could edit the body or post a comment though.
For what it's worth, the Summary report posted on the PR will automatically inject a condition for a valid Depends-On which indicates the PR it is waiting for. I imagine it's less visible than an emoji or comment, but the information is there.
Expected Behavior
Sometimes the changes for
feature/B
depend on the changes forfeature/A
. TheDepends-On: #1234
syntax allows me to block mergingfeature/B
until the PR forfeature/A
merges, but a small typo can make that fail silently.It would be nice if there was an obvious user-facing confirmation that
Depends-On:
was parsed successfully. One option would be to post a comment, like the existing "Mergify rebased successfully" comment. Another option would be an emoji on the PR description, like what is done when commenting "@Mergifyio rebase".Actual Behavior
depends-on: #1234
,depends on: #1234
,Depends-On #1234
etc don't create a dependency, but look correct at first glance.Steps to Reproduce the Problem
Depends-On: #1
to PR#2
, but get the syntax wrong#2
and watch it merge automaticallySpecifications
The text was updated successfully, but these errors were encountered: