Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirmation message for Depends-On: #5050

Open
hansen-matt opened this issue Oct 31, 2022 · 1 comment
Open

Confirmation message for Depends-On: #5050

hansen-matt opened this issue Oct 31, 2022 · 1 comment

Comments

@hansen-matt
Copy link

hansen-matt commented Oct 31, 2022

Expected Behavior

Sometimes the changes for feature/B depend on the changes for feature/A. The Depends-On: #1234 syntax allows me to block merging feature/B until the PR for feature/A merges, but a small typo can make that fail silently.

It would be nice if there was an obvious user-facing confirmation that Depends-On: was parsed successfully. One option would be to post a comment, like the existing "Mergify rebased successfully" comment. Another option would be an emoji on the PR description, like what is done when commenting "@Mergifyio rebase".

Actual Behavior

depends-on: #1234, depends on: #1234, Depends-On #1234 etc don't create a dependency, but look correct at first glance.

Steps to Reproduce the Problem

  1. Create two PRs
  2. Add Depends-On: #1 to PR #2, but get the syntax wrong
  3. Approve PR #2 and watch it merge automatically

Specifications

  • Pull Request URL:
  • Mergify Config URL:
@jd
Copy link
Member

jd commented Oct 31, 2022

Hi @hansen-matt,

Those are great suggestions, thank you. I'm not sure how to do this right now:

The emoji reactions are pretty limited. If we could react with 🔗 it could be cool but that's not in the list of allowed reactions. We could edit the body or post a comment though.

For what it's worth, the Summary report posted on the PR will automatically inject a condition for a valid Depends-On which indicates the PR it is waiting for. I imagine it's less visible than an emoji or comment, but the information is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants