-
Notifications
You must be signed in to change notification settings - Fork 49
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Are there any linked Issues or Pull Requests?
No response
Brief description
During the review of PR #65 , the code reviewer has pointed out that functionalities in Stochastic Physics Psyclone scripts can be grouped into functions and relocated to https://github.com/MetOffice/lfric_core/blob/main/infrastructure/build/psyclone/psyclone_tools.py , for reuse by different PSyclone scripts. This can improve the modularity and reduce the length and duplication of the Psyclone script.
Further details of the issue.
The details are in the conversations of PR #65 during the code review stage. Specifically, the current issues of the Stochastic Physics Psyclone scripts are:
- Duplication of codes between different Stochastic Physics Psyclone scripts.
- Logics of initializing different transforms based on
OFFLOAD_DIRECTIVEScan be grouped into a function. - Some parts of the codes can be replaced by calling
redundant_computation__setvalandcolour_loops. - GPU-related transformation codes can be grouped into a function with better if and try logic.
- OpenMP transformation codes can also be grouped into a function.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request