From bdc2f926d997ef3a124c9c4211ba0b33ea20183c Mon Sep 17 00:00:00 2001 From: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> Date: Fri, 9 Jan 2026 15:22:38 +0000 Subject: [PATCH 1/2] Reformat pull request template --- .github/pull_request_template.md | 42 +++++++++----------------------- 1 file changed, 12 insertions(+), 30 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index e5495deae..920e1419c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -22,28 +22,19 @@ Code Reviewer: ## Code Quality Checklist -(_Some checks are automatically carried out via the CI pipeline_) - - [ ] I have performed a self-review of my own code -- [ ] My code follows the project's - [style guidelines](https://metoffice.github.io/lfric_core/how_to_contribute/index.html#how-to-contribute-index) -- [ ] Comments have been included that aid understanding and enhance the - readability of the code +- [ ] My code follows the project's [style guidelines](https://metoffice.github.io/lfric_core/how_to_contribute/index.html#how-to-contribute-index) +- [ ] Comments have been included that aid understanding and enhance the readability of the code - [ ] My changes generate no new warnings +- [ ] All automated checks in the CI pipeline have completed successfully ## Testing - [ ] I have tested this change locally, using the LFRic Core rose-stem suite -- [ ] If required (e.g. API changes) I have also run the LFRic Apps test suite - using this branch -- [ ] If any tests fail (rose-stem or CI) the reason is understood and - acceptable (e.g. kgo changes) -- [ ] I have added tests to cover new functionality as appropriate (e.g. system - tests, unit tests, etc.) -- [ ] Any new tests have been assigned an appropriate amount of compute resource - and have been allocated to an appropriate testing group (i.e. the - developer tests are for jobs which use a small amount of compute resource - and complete in a matter of minutes) +- [ ] If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch +- [ ] If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes) +- [ ] I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.) +- [ ] Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes) @@ -59,30 +50,21 @@ Code Reviewer: ## Performance Impact -- [ ] Performance of the code has been considered and, if applicable, suitable - performance measurements have been conducted +- [ ] Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted ## AI Assistance and Attribution -- [ ] Some of the content of this change has been produced with the assistance - of _Generative AI tool name_ (e.g., Met Office Github Copilot Enterprise, - Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the - [Simulation Systems AI policy](https://metoffice.github.io/simulation-systems/FurtherDetails/ai.html) - (including attribution labels) +- [ ] Some of the content of this change has been produced with the assistance of _Generative AI tool name_ (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the [Simulation Systems AI policy](https://metoffice.github.io/simulation-systems/FurtherDetails/ai.html) (including attribution labels) ## Documentation -- [ ] Where appropriate I have updated documentation related to this change and - confirmed that it builds correctly +- [ ] Where appropriate I have updated documentation related to this change and confirmed that it builds correctly ## PSyclone Approval -- [ ] If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel - interface, optimisation scripts, LFRic data structure code) then please - contact the - [tooscollabdevteam@metoffice.gov.uk](tooscollabdevteam@metoffice.gov.uk) +- [ ] If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the [TCD Team](tooscollabdevteam@metoffice.gov.uk) # Sci/Tech Review @@ -94,7 +76,7 @@ Code Reviewer: - [ ] Documentation is sufficient (do documentation papers need updating) - [ ] Sufficient testing has been completed -_Please alert the code reviewer via a tag when you have approved the SR_ +(_Please alert the code reviewer via a tag when you have approved the SR_) # Code Review From 108fc0c18916d33095452e4effe1db6a56220fda Mon Sep 17 00:00:00 2001 From: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com> Date: Wed, 21 Jan 2026 10:13:44 +0000 Subject: [PATCH 2/2] Update .github/pull_request_template.md Co-authored-by: Andrew Coughtrie <24609575+andrewcoughtrie@users.noreply.github.com> --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 920e1419c..28a52203a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -64,7 +64,7 @@ Code Reviewer: ## PSyclone Approval -- [ ] If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the [TCD Team](tooscollabdevteam@metoffice.gov.uk) +- [ ] If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the [TCD Team](mailto:ToolsCollabDevTeam@metoffice.gov.uk) # Sci/Tech Review