refactor: simplify home tabs

Author: n3ps

app/scripts/constants/sentry-state.ts

@@ -58,7 +58,6 @@ export const SENTRY_BACKGROUND_STATE = {
     currentPopupId: false,
     onboardingDate: false,
     currentExtensionPopupId: false,
-    defaultHomeActiveTabName: true,
     enableEnforcedSimulations: true,
     enableEnforcedSimulationsForTransactions: false,
     fullScreenGasPollTokens: true,

app/scripts/controllers/app-state-controller.test.ts

@@ -12,7 +12,6 @@ import {
   ORIGIN_METAMASK,
   POLLING_TOKEN_ENVIRONMENT_TYPES,
 } from '../../../shared/constants/app';
-import { AccountOverviewTabKey } from '../../../shared/constants/app-state';
 import { MINUTE } from '../../../shared/constants/time';
 import { AppStateController } from './app-state-controller';
 import type {
@@ -188,18 +187,6 @@ describe('AppStateController', () => {
     });
   });
 
-  describe('setDefaultHomeActiveTabName', () => {
-    it('sets the default home tab name', async () => {
-      await withController(({ controller }) => {
-        controller.setDefaultHomeActiveTabName(AccountOverviewTabKey.Activity);
-
-        expect(controller.state.defaultHomeActiveTabName).toBe(
-          AccountOverviewTabKey.Activity,
-        );
-      });
-    });
-  });
-
   describe('setConnectedStatusPopoverHasBeenShown', () => {
     it('sets connected status popover as shown', async () => {
       await withController(({ controller }) => {
@@ -763,7 +750,6 @@ describe('AppStateController', () => {
               "connectedStatusPopoverHasBeenShown": true,
               "currentExtensionPopupId": 0,
               "currentPopupId": 0,
-              "defaultHomeActiveTabName": null,
               "enableEnforcedSimulations": true,
               "enableEnforcedSimulationsForTransactions": {},
               "enforcedSimulationsSlippage": 10,
@@ -852,7 +838,6 @@ describe('AppStateController', () => {
               "connectedStatusPopoverHasBeenShown": true,
               "currentExtensionPopupId": 0,
               "currentPopupId": 0,
-              "defaultHomeActiveTabName": null,
               "enableEnforcedSimulations": true,
               "enableEnforcedSimulationsForTransactions": {},
               "enforcedSimulationsSlippage": 10,
@@ -937,7 +922,6 @@ describe('AppStateController', () => {
               "browserEnvironment": {},
               "canTrackWalletFundsObtained": true,
               "connectedStatusPopoverHasBeenShown": true,
-              "defaultHomeActiveTabName": null,
               "enableEnforcedSimulations": true,
               "enforcedSimulationsSlippage": 10,
               "hadAdvancedGasFeesSetPriorToMigration92_3": false,
@@ -1017,7 +1001,6 @@ describe('AppStateController', () => {
               "connectedStatusPopoverHasBeenShown": true,
               "currentExtensionPopupId": 0,
               "currentPopupId": 0,
-              "defaultHomeActiveTabName": null,
               "enableEnforcedSimulations": true,
               "enableEnforcedSimulationsForTransactions": {},
               "enforcedSimulationsSlippage": 10,

app/scripts/controllers/app-state-controller.ts

@@ -73,7 +73,6 @@ export type AppStateControllerState = {
   // States used for displaying the changed network toast
   currentExtensionPopupId: number;
   currentPopupId?: number;
-  defaultHomeActiveTabName: AccountOverviewTabKey | null;
   enableEnforcedSimulations: boolean;
   enableEnforcedSimulationsForTransactions: Record<string, boolean>;
   enforcedSimulationsSlippage: number;
@@ -234,7 +233,6 @@ const getDefaultAppStateControllerState = (): AppStateControllerState => ({
   appActiveTab: undefined,
   browserEnvironment: {},
   connectedStatusPopoverHasBeenShown: true,
-  defaultHomeActiveTabName: null,
   enableEnforcedSimulations: true,
   enableEnforcedSimulationsForTransactions: {},
   enforcedSimulationsSlippage: 10,
@@ -342,12 +340,6 @@ const controllerMetadata: StateMetadata<AppStateControllerState> = {
     includeInDebugSnapshot: true,
     usedInUi: true,
   },
-  defaultHomeActiveTabName: {
-    includeInStateLogs: true,
-    persist: true,
-    includeInDebugSnapshot: true,
-    usedInUi: true,
-  },
   enableEnforcedSimulations: {
     includeInStateLogs: true,
     persist: true,
@@ -757,19 +749,6 @@ export class AppStateController extends BaseController<
     this.#acceptApproval();
   }
 
-  /**
-   * Sets the default home tab
-   *
-   * @param defaultHomeActiveTabName - the tab name
-   */
-  setDefaultHomeActiveTabName(
-    defaultHomeActiveTabName: AccountOverviewTabKey | null,
-  ): void {
-    this.update((state) => {
-      state.defaultHomeActiveTabName = defaultHomeActiveTabName;
-    });
-  }
-
   /**
    * Record that the user has seen the connected status info popover
    */

app/scripts/metamask-controller.js

@@ -2768,8 +2768,6 @@ export default class MetamaskController extends EventEmitter {
         appStateController.setCurrentExtensionPopupId.bind(appStateController),
       setBrowserEnvironment:
         appStateController.setBrowserEnvironment.bind(appStateController),
-      setDefaultHomeActiveTabName:
-        appStateController.setDefaultHomeActiveTabName.bind(appStateController),
       setConnectedStatusPopoverHasBeenShown:
         appStateController.setConnectedStatusPopoverHasBeenShown.bind(
           appStateController,

shared/types/background.ts

@@ -93,7 +93,6 @@ export type ControllerStatePropertiesEnumerated = {
   pendingApprovalCount: ApprovalControllerState['pendingApprovalCount'];
   timeoutMinutes: AppStateControllerState['timeoutMinutes'];
   connectedStatusPopoverHasBeenShown: AppStateControllerState['connectedStatusPopoverHasBeenShown'];
-  defaultHomeActiveTabName: AppStateControllerState['defaultHomeActiveTabName'];
   browserEnvironment: AppStateControllerState['browserEnvironment'];
   popupGasPollTokens: AppStateControllerState['popupGasPollTokens'];
   notificationGasPollTokens: AppStateControllerState['notificationGasPollTokens'];

test/e2e/default-fixture.js

@@ -108,7 +108,6 @@ function defaultFixture(inputChainId = CHAIN_IDS.LOCALHOST) {
         connectedStatusPopoverHasBeenShown: true,
         termsOfUseLastAgreed:
           '__FIXTURE_SUBSTITUTION__currentDateInMilliseconds',
-        defaultHomeActiveTabName: null,
         fullScreenGasPollTokens: [],
         notificationGasPollTokens: [],
         popupGasPollTokens: [],

test/e2e/fixtures/onboarding-fixture.json

@@ -48,7 +48,6 @@
         "os": "mac"
       },
       "connectedStatusPopoverHasBeenShown": true,
-      "defaultHomeActiveTabName": null,
       "enableEnforcedSimulations": true,
       "enforcedSimulationsSlippage": 10,
       "hadAdvancedGasFeesSetPriorToMigration92_3": false,

test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-background-state.json

@@ -33,7 +33,6 @@
     "browserEnvironment": { "os": "string", "browser": "string" },
     "canTrackWalletFundsObtained": false,
     "connectedStatusPopoverHasBeenShown": true,
-    "defaultHomeActiveTabName": null,
     "enableEnforcedSimulations": true,
     "enableEnforcedSimulationsForTransactions": "object",
     "enforcedSimulationsSlippage": "number",

test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-ui-state.json

@@ -136,7 +136,6 @@
     "appActiveTab": "object",
     "browserEnvironment": { "os": "string", "browser": "string" },
     "connectedStatusPopoverHasBeenShown": true,
-    "defaultHomeActiveTabName": null,
     "enableEnforcedSimulations": true,
     "enableEnforcedSimulationsForTransactions": "object",
     "enforcedSimulationsSlippage": "number",

test/e2e/tests/metrics/state-snapshots/errors-before-init-opt-in-background-state.json

@@ -37,7 +37,6 @@
       "nftsDropdownState": {},
       "connectedStatusPopoverHasBeenShown": true,
       "termsOfUseLastAgreed": "number",
-      "defaultHomeActiveTabName": null,
       "fullScreenGasPollTokens": "object",
       "notificationGasPollTokens": "object",
       "popupGasPollTokens": "object",