Skip to content

Conversation

@lionellbriones
Copy link
Contributor

@lionellbriones lionellbriones commented Nov 28, 2025

Description

  • adds reward points details on shield plan
  • adds shield reward points modal

Open in GitHub Codespaces

Changelog

CHANGELOG entry: adds shield rewards modal

Related issues

Fixes:

Manual testing steps

  1. Login to MetaMask with an account without shield subscription
  2. Go to Menu > Settings : click on Transaction Shield
  3. Shows Shield Entry modal: click on get started
  4. Redirects to Shield plan form
  5. Observe what you get list
  6. Click on Rewards detail
  7. Shows Rewards modal

Screenshots/Recordings

Before

After

Yearly view
Screenshot 2025-11-28 at 2 37 41 PM

Monthly view
Screenshot 2025-11-28 at 2 38 05 PM

Rewards modal
Screenshot 2025-11-28 at 2 37 46 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Nov 28, 2025
@metamaskbot
Copy link
Collaborator

✨ Files requiring CODEOWNER review ✨

🔐 @MetaMask/web3auth (2 files, +109 -0)
  • 📁 ui/
    • 📁 pages/
      • 📁 shield-plan/
        • 📄 shield-plan.tsx +27 -0
        • 📄 shield-rewards-modal.tsx +82 -0

@lionellbriones lionellbriones added team-shield Shield team and removed team-onboarding Onboarding team labels Nov 28, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [b8020e0]
UI Startup Metrics (1220 ± 115 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyStandard HomeuiStartup12201002163311513041426
load1028864144110410891227
domContentLoaded1023859143310310831216
domInteractive251588192083
firstPaint4878612313839541173
backgroundConnect21218927513215238
firstReactRender301962103354
getState3414113153962
initialActions106112
loadScripts8166611231101871988
setupStore1162941318
numNetworkReqs1257721573
BrowserifyPower User HomeuiStartup21061794288826422712658
load1028898152813810311399
domContentLoaded1013885150613710171390
domInteractive35181322332109
firstPaint5278315224069581365
backgroundConnect267200811120232561
firstReactRender574096126287
getState20214075996203301
initialActions108113
loadScripts80567712951377931191
setupStore21115082640
numNetworkReqs1496939870203302
WebpackStandard HomeuiStartup8597191136948981064
load65758088572680826
domContentLoaded65257688072676820
domInteractive2816136242296
firstPaint21089677125200601
backgroundConnect1054761127
firstReactRender3220290273442
getState281391133649
initialActions105112
loadScripts64957487170674811
setupStore1174151319
numNetworkReqs1257720573
WebpackPower User HomeuiStartup17041335235227019652187
load6895911013101690956
domContentLoaded6795831007102678949
domInteractive37181923434137
firstPaint27887958185266669
backgroundConnect99761818521567
firstReactRender624492106984
getState18313877280181221
initialActions103112
loadScripts676581998100675940
setupStore1995692248
numNetworkReqs1626639780211387
FirefoxBrowserifyStandard HomeuiStartup13391128174514714381621
load109793113438611581259
domContentLoaded109793113428711571258
domInteractive64311633190124
firstPaint------
backgroundConnect50221983457128
firstReactRender24195672439
getState176216321072
initialActions103122
loadScripts106691512567611151213
setupStore155151201263
numNetworkReqs1156816761
BrowserifyPower User HomeuiStartup26092022424038027213635
load11801025161013911851535
domContentLoaded11801025160913911851535
domInteractive12837582115115457
firstPaint------
backgroundConnect121281046124118372
firstReactRender6138135166598
getState28049916214315818
initialActions3040526
loadScripts11461002158613411511484
setupStore1688849208193713
numNetworkReqs100593036179239
WebpackStandard HomeuiStartup15041281205114715851773
load12521075162010213041434
domContentLoaded12521074162010213041434
domInteractive57251563585132
firstPaint------
backgroundConnect47201922947118
firstReactRender261990102635
getState1871913113110
initialActions102122
loadScripts1226105815959712791393
setupStore1267391334
numNetworkReqs1156515753
WebpackPower User HomeuiStartup29552313622168829864544
load14021137277530113822190
domContentLoaded14011137277530113822190
domInteractive10729493104100414
firstPaint------
backgroundConnect13130961118130340
firstReactRender71412443667184
getState327851741284543790
initialActions208123
loadScripts13591117259627313332091
setupStore12461143197129620
numNetworkReqs101592526079244
📊 Page Load Benchmark Results

Current Commit: b8020e0 | Date: 11/28/2025

📄 Localhost MetaMask Test Dapp

Samples: 100

Summary

  • pageLoadTime-> current mean value: 1.05s (±49ms) 🟡 | historical mean value: 1.03s ⬆️ (historical data)
  • domContentLoaded-> current mean value: 736ms (±64ms) 🟢 | historical mean value: 720ms ⬆️ (historical data)
  • firstContentfulPaint-> current mean value: 91ms (±128ms) 🟢 | historical mean value: 77ms ⬆️ (historical data)

📈 Detailed Results

Metric Mean Std Dev Min Max P95 P99
pageLoadTime 1.05s 49ms 1.02s 1.40s 1.10s 1.40s
domContentLoaded 736ms 64ms 707ms 1.29s 748ms 1.29s
firstPaint 91ms 128ms 60ms 1.36s 88ms 1.36s
firstContentfulPaint 91ms 128ms 60ms 1.36s 88ms 1.36s
largestContentfulPaint 0ms 0ms 0ms 0ms 0ms 0ms
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 58 Bytes (0%)
  • ui: 3.29 KiB (0.04%)
  • common: 344 Bytes (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants