feat: transaction pay controller #38397
Open
+2,071
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewwalsh0
added
team-confirmations
matthewwalsh0
force-pushed
the
feat/transaction-pay-controller
branch
from
d7fc47d to
fb87fc9
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (1 files, +1 -0)
🧩 @MetaMask/extension-devs (6 files, +1271 -24)
📜 @MetaMask/policy-reviewers (6 files, +1271 -24)
Tip Follow the policy review process outlined in the LavaMoat Policy Review Process doc before expecting an approval from Policy Reviewers. 🔗 @MetaMask/supply-chain (6 files, +1271 -24)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Member
Author
|
@SocketSecurity ignore-all |
Member
Author
|
@metamaskbot update-policies |
Collaborator
Builds ready [fb87fc9]
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
|
Policy update failed. You can review the logs or retry the policy update here |
1 similar comment
Collaborator
|
Policy update failed. You can review the logs or retry the policy update here |
Member
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated. 🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff |
Collaborator
Builds ready [66c58a1]
UI Startup Metrics (1226 ± 99 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
TransactionPayController.No functional changes yet.
Changelog
CHANGELOG entry: null
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Integrates
TransactionPayControllerwith initialization, restricted messengers, tests, wiring into controller registry/bootstrap, and updates Lavamoat policies and dependencies.TransactionPayControllerinit inapp/scripts/controller-init/transaction-pay-controller-init.ts(defaultRelaystrategy) and include inmetamask-controllerbootstrap andcontroller-list/state unions.app/scripts/controller-init/messengers/transaction-pay-controller-messenger.tsand export viaapp/scripts/controller-init/messengers/index.ts.transaction-pay-controller-init.test.ts,transaction-pay-controller-messenger.test.ts).CONTROLLER_MESSENGERSandutils.tscontroller initialization map.confirmations/transaction-controller-init.ts.@metamask/transaction-pay-controllerand related transitive deps.@metamask/transaction-pay-controller@^10.2.0and bump@metamask/transaction-controllerto^62.3.1, with related package/version updates to support integration.Written by Cursor Bugbot for commit 66c58a1. This will update automatically on new commits. Configure here.