fix: dapp swap comparison: use middleware for transaction decoding #38406
+108
−169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpuri
added
team-confirmations
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
✨ Files requiring CODEOWNER review ✨✅ @MetaMask/confirmations (5 files, +87 -143)
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| srcTokenAmount: quotesInput?.srcTokenAmount as Hex, | ||
| destTokenAmountMin: amountMin as Hex, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
Bug: Missing commands in successful swap comparison data storage
The commands variable is parsed from transaction data at line 106 but is never stored in setDappSwapComparisonData during the success path. The initial call (lines 117-124) stores only swapInfo, and the successful quote fetch callback (lines 135-138) stores only quotes and latency. Only error handlers include commands. The UI code expects commands from dappSwapComparisonData to populate metrics like swap_dapp_commands. Since commands isn't stored on success, metrics will incorrectly receive empty strings for this field.
Collaborator
Builds ready [2c7106e]
UI Startup Metrics (1208 ± 113 ms)
📊 Page Load Benchmark ResultsCurrent Commit: 📄 Localhost MetaMask Test DappSamples: 100 Summary
📈 Detailed Results
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dapp swap comparison related code cleanup.
Changelog
CHANGELOG entry:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/6346
Manual testing steps
Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Moves swap tx decoding to middleware, introduces
swapInfostorage with incremental updates, simplifies UI hooks/metrics, and removes deprecatedtokenAddresses.swapInfotoDappSwapComparisonData(src/dest token addresses and amounts); removetokenAddresses.setDappSwapComparisonDatanow merges per-transaction updates instead of overwriting.app/scripts/lib/dapp-swap/dapp-swap-util.ts):amountMin; persistswapInfovia controller before fetching quotes.commandson errors; droptokenAddresses.getDataFromSwapreturns command values directly; associated tests updated (notokenAddresses).useDappSwapComparisonInfo: remove in-UI decoding and batch validation; consume middleware-providedswapInfo/commands; compute metrics usingswapInfo.destTokenAmountMin; remove request detection latency property.useDappSwapComparisonLatencyMetrics: remove request detection latency tracking; keep total latency.swapInfo.swapInfoshape, metrics, and removed fields.Written by Cursor Bugbot for commit 39caf8c. This will update automatically on new commits. Configure here.