From cd796ce5ff0176c2c6711556fb72e9f9c6eab53e Mon Sep 17 00:00:00 2001 From: Nico MASSART Date: Fri, 31 May 2024 22:41:50 +0200 Subject: [PATCH] fix: update Delete MetaMetrics Data copy to 30 days (#9674) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## **Description** - Update copy from 60 to 30 days - Update initial text to remove part two and add a link on Metametrics (requires to split text in 3 parts) See [change request comment](https://github.com/MetaMask/metamask-mobile/pull/9674#issuecomment-2117943077) - The text change required to reorganise keys. - New more explicit names used to clarify code and ease translation ## **Related issues** fixes MetaMask/mobile-planning#1797 ## **Manual testing steps** 1. Go to settings / Security & Privacy. 2. scroll to "delete metametrics data" section. 3. check description matches [@hesterbruikman comment](https://github.com/MetaMask/metamask-mobile/pull/9674#issuecomment-2117943077): > This will delete historical [MetaMetrics](https://support.metamask.io/privacy-and-security/how-to-manage-your-metametrics-settings/) data associated with your use on this device. Your wallet and accounts will remain exactly as they are now after this data has been deleted. This process may take up to 30 days. View our [Privacy Policy](https://consensys.io/privacy-policy). 5. Check "MetaMetrics" and "Privacy Policy" links. 6. Touch "Delete MetaMetrics Data" button. 7. Touch "CLEAR" in the confirmation popup. 8. Check the confirmation message says "30 days". 9. Check "Privacy Policy" link. ## **Screenshots/Recordings** https://github.com/MetaMask/metamask-mobile/assets/4677568/5402c2bf-f203-4d71-9818-7abdec3b860c ### **Before** ### **After** ![image](https://github.com/MetaMask/metamask-mobile/assets/4677568/f89d685a-c4a3-4807-9e1b-a2298c78224e) ![image](https://github.com/MetaMask/metamask-mobile/assets/4677568/fa72f009-9a47-4bd7-a899-12ad163b699a) ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: sethkfman --- .../Sections/DeleteMetaMetricsData.tsx | 39 +++++++++++++----- .../SecuritySettings.test.tsx.snap | 41 ++++++++++++++++--- app/constants/urls.ts | 3 ++ locales/languages/de.json | 6 --- locales/languages/el.json | 6 --- locales/languages/en.json | 15 +++---- locales/languages/es.json | 6 --- locales/languages/fr.json | 6 --- locales/languages/hi.json | 6 --- locales/languages/id.json | 6 --- locales/languages/ja.json | 6 --- locales/languages/ko.json | 6 --- locales/languages/pt.json | 6 --- locales/languages/ru.json | 6 --- locales/languages/tl.json | 6 --- locales/languages/tr.json | 6 --- locales/languages/vi.json | 6 --- locales/languages/zh.json | 6 --- 18 files changed, 75 insertions(+), 107 deletions(-) diff --git a/app/components/Views/Settings/SecuritySettings/Sections/DeleteMetaMetricsData.tsx b/app/components/Views/Settings/SecuritySettings/Sections/DeleteMetaMetricsData.tsx index 05813b53b2f..2427a73c958 100644 --- a/app/components/Views/Settings/SecuritySettings/Sections/DeleteMetaMetricsData.tsx +++ b/app/components/Views/Settings/SecuritySettings/Sections/DeleteMetaMetricsData.tsx @@ -7,7 +7,10 @@ import { import { useMetrics } from '../../../../hooks/useMetrics'; import SettingsButtonSection from '../../../../UI/SettingsButtonSection'; import { strings } from '../../../../../../locales/i18n'; -import { CONSENSYS_PRIVACY_POLICY } from '../../../../../constants/urls'; +import { + CONSENSYS_PRIVACY_POLICY, + HOWTO_MANAGE_METAMETRICS, +} from '../../../../../constants/urls'; import Logger from '../../../../../util/Logger'; import { getBrand, getDeviceId } from 'react-native-device-info'; import Text, { @@ -161,6 +164,7 @@ const DeleteMetaMetricsData = (props: DeleteMetaMetricsDataProps) => { }, [metricsOptin, checkInitialStatus, setDataTrackedSinceLastDeletion]); const openPrivacyPolicy = () => Linking.openURL(CONSENSYS_PRIVACY_POLICY); + const openMetametricsHowto = () => Linking.openURL(HOWTO_MANAGE_METAMETRICS); return ( { {strings('app_settings.delete_metrics_description_part_one')} {' '} - - {strings('app_settings.delete_metrics_description_part_two')} - {' '} +