Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add selected payment type for ramps sell e2e #12951

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

cortisiko
Copy link
Member

Description

The sell e2e is failing because no sell quotes were available. I made changes in the e2e to explicitly use a selected payment type: debit-credit

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cortisiko cortisiko added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise area-qa Relating to QA work (Quality Assurance) labels Jan 10, 2025
@cortisiko cortisiko self-assigned this Jan 10, 2025
@cortisiko cortisiko requested review from a team as code owners January 10, 2025 23:57
@cortisiko cortisiko added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8e66b5a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/baa57313-465b-4875-b0ff-ef3d9464c279

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@MetaMask MetaMask deleted a comment from github-actions bot Jan 11, 2025
@cortisiko cortisiko enabled auto-merge January 11, 2025 00:00
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.74%. Comparing base (6b68dd7) to head (8e66b5a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12951      +/-   ##
==========================================
+ Coverage   59.72%   59.74%   +0.01%     
==========================================
  Files        1865     1865              
  Lines       42011    42012       +1     
  Branches     5458     5454       -4     
==========================================
+ Hits        25093    25101       +8     
+ Misses      15239    15236       -3     
+ Partials     1679     1675       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-qa Relating to QA work (Quality Assurance) No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E Triggers smoke e2e on Bitrise team-mobile-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants