Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade eslint-plugin-import to ~2.26.0 #231

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Nov 3, 2023

Versions >=2.27.0 of eslint-plugin-import have a regression, causing the import order to change. The recommended version in the ESLint config is ~2.26.0 for now.

@Mrtenz Mrtenz requested a review from a team as a code owner November 3, 2023 11:08
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
eslint-plugin-import 2.29.0...2.26.0 None +3/-1 1.12 MB ljharb

@@ -55,7 +55,7 @@
"depcheck": "^1.4.3",
"eslint": "^8.44.0",
"eslint-config-prettier": "^8.8.0",
"eslint-plugin-import": "^2.27.5",
"eslint-plugin-import": "~2.26.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we go ahead and bump to ^2.29.0? It looks like there is a fix for something in 2.28.1, but I'm not sure if it's what you're referring to: https://github.com/import-js/eslint-plugin-import/blob/main/CHANGELOG.md#fixed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Thanks for following up!

Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Mrtenz Mrtenz merged commit 9559d44 into main Nov 6, 2023
14 checks passed
@Mrtenz Mrtenz deleted the mrtenz/eslint-plugin-imoprt@2.26.0 branch November 6, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants