Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration instructions for Meteor 3 #7

Open
perbergland opened this issue Apr 24, 2024 · 3 comments
Open

Add migration instructions for Meteor 3 #7

perbergland opened this issue Apr 24, 2024 · 3 comments

Comments

@perbergland
Copy link

Add a deprecation notice to the readme and instructions on how to migrate the code to Meteor 3 and its Express-based webapp

Copy link

Thank you for submitting this issue!

We, the Members of Meteor Community Packages take every issue seriously.
Our goal is to provide long-term lifecycles for packages and keep up
with the newest changes in Meteor and the overall NodeJs/JavaScript ecosystem.

However, we contribute to these packages mostly in our free time.
Therefore, we can't guarantee your issues to be solved within certain time.

If you think this issue is trivial to solve, don't hesitate to submit
a pull request, too! We will accompany you in the process with reviews and hints
on how to get development set up.

Please also consider sponsoring the maintainers of the package.
If you don't know who is currently maintaining this package, just leave a comment
and we'll let you know

StorytellerCZ added a commit that referenced this issue May 4, 2024
@StorytellerCZ
Copy link
Member

Added initial deprecation notice. Will release deprecated version 1.2.0 to draw more attention to this and then as I migrate my app will add a migration guide.

@matheusccastroo
Copy link

matheusccastroo commented May 24, 2024

@perbergland @StorytellerCZ Not sure I understood why it needs to be deprecated.

This package creates a router that enables to pass params through the url and have some additional fancy stuff with filters etc. Does express have a direct mapping with those features?

Taking a look here, seems that express have the req.params for the url named parameters and also the filter is actually simple to implement too. Gotcha, now makes more sense 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants