From 258f745abab14d4e3d9b8fe576dff858cf2e30a7 Mon Sep 17 00:00:00 2001
From: Brian Pepple <bdpepple@gmail.com>
Date: Sun, 17 Nov 2024 08:38:12 -0500
Subject: [PATCH] Additional Information Source Enums (#59)

* Add additional `informationSource` enums

- Kitsu
- MangaDex
- MangaUpdates

* Change `id` data types from int to string

Kitsu & Mangadex use id's that contain alphanumeric characters and hyphens, so we need to change the `id` data types to support these.
---
 drafts/v1.0/MetronInfo.xsd | 23 +++++++++++++----------
 drafts/v1.0/Sample.xml     |  1 +
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/drafts/v1.0/MetronInfo.xsd b/drafts/v1.0/MetronInfo.xsd
index 4d45091..38725bc 100644
--- a/drafts/v1.0/MetronInfo.xsd
+++ b/drafts/v1.0/MetronInfo.xsd
@@ -58,7 +58,7 @@
 
     <xs:complexType name="idType">
         <xs:simpleContent>
-            <xs:extension base="xs:positiveInteger">
+            <xs:extension base="xs:string">
                 <xs:attribute name="source" type="informationSource" use="required" />
                 <xs:attribute name="primary" type="xs:boolean" />
             </xs:extension>
@@ -75,7 +75,7 @@
     <xs:complexType name="resourceType">
         <xs:simpleContent>
             <xs:extension base="xs:string">
-                <xs:attribute name="id" type="xs:positiveInteger" />
+                <xs:attribute name="id" type="xs:string" />
             </xs:extension>
         </xs:simpleContent>
     </xs:complexType>
@@ -85,7 +85,7 @@
             <xs:element name="Name" type="xs:string" />
             <xs:element name="Imprint" type="resourceType" minOccurs="0" />
         </xs:all>
-        <xs:attribute name="id" type="xs:positiveInteger" />
+        <xs:attribute name="id" type="xs:string" />
     </xs:complexType>
 
     <xs:complexType name="seriesType">
@@ -100,7 +100,7 @@
             <xs:element name="AlternativeNames" type="alternativeNameType" minOccurs="0" />
         </xs:all>
         <xs:attribute name="lang" type="languageCode" default="en" />
-        <xs:attribute name="id" type="xs:positiveInteger" />
+        <xs:attribute name="id" type="xs:string" />
     </xs:complexType>
 
     <xs:complexType name="alternativeNameType">
@@ -113,7 +113,7 @@
     <xs:complexType name="nameType">
         <xs:simpleContent>
             <xs:extension base="xs:string">
-                <xs:attribute name="id" type="xs:positiveInteger" />
+                <xs:attribute name="id" type="xs:string" />
                 <xs:attribute name="lang" type="languageCode" default="en" />
             </xs:extension>
         </xs:simpleContent>
@@ -160,7 +160,7 @@
             <xs:element name="Name" type="xs:string" />
             <xs:element name="Designation" type="xs:string" minOccurs="0" />
         </xs:all>
-        <xs:attribute name="id" type="xs:positiveInteger" />
+        <xs:attribute name="id" type="xs:string" />
     </xs:complexType>
 
     <xs:complexType name="arcsType">
@@ -174,7 +174,7 @@
             <xs:element name="Name" type="xs:string" />
             <xs:element name="Number" type="xs:positiveInteger" minOccurs="0" />
         </xs:all>
-        <xs:attribute name="id" type="xs:positiveInteger" />
+        <xs:attribute name="id" type="xs:string" />
     </xs:complexType>
 
     <xs:complexType name="creditsType">
@@ -186,7 +186,7 @@
     <xs:complexType name="roleType">
         <xs:simpleContent>
             <xs:extension base="roleValues">
-                <xs:attribute name="id" type="xs:positiveInteger" />
+                <xs:attribute name="id" type="xs:string" />
             </xs:extension>
         </xs:simpleContent>
     </xs:complexType>
@@ -207,7 +207,7 @@
     <xs:complexType name="genreType">
         <xs:simpleContent>
             <xs:extension base="xs:string">
-                <xs:attribute name="id" type="xs:positiveInteger" />
+                <xs:attribute name="id" type="xs:string" />
             </xs:extension>
         </xs:simpleContent>
     </xs:complexType>
@@ -259,6 +259,9 @@
             <xs:enumeration value="AniList" />
             <xs:enumeration value="Comic Vine" />
             <xs:enumeration value="Grand Comics Database" />
+            <xs:enumeration value="Kitsu" />  <!-- ID's contain letters, hyphens, and numbers -->
+            <xs:enumeration value="MangaDex" /> <!-- ID's contain letters, hyphens, and numbers -->
+            <xs:enumeration value="MangaUpdates" />
             <xs:enumeration value="Marvel" />
             <xs:enumeration value="Metron" />
             <xs:enumeration value="MyAnimeList" />
@@ -341,4 +344,4 @@
             <xs:pattern value="[a-z][a-z]" />
         </xs:restriction>
     </xs:simpleType>
-</xs:schema>
\ No newline at end of file
+</xs:schema>
diff --git a/drafts/v1.0/Sample.xml b/drafts/v1.0/Sample.xml
index d8179d1..8a1ceb1 100644
--- a/drafts/v1.0/Sample.xml
+++ b/drafts/v1.0/Sample.xml
@@ -4,6 +4,7 @@
         <ID source="Metron" primary="true">290431</ID>
         <ID source="Comic Vine">12345</ID>
         <ID source="Grand Comics Database">543</ID>
+        <ID source="MangaDex">8b34f37a-0181-4f0b-8ce3-01217e9a602c</ID>
     </IDS>
     <Publisher id="12345">
         <Name>DC Comics</Name>