Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorisations #10

Open
willtebbutt opened this issue Jul 23, 2019 · 6 comments
Open

Factorisations #10

willtebbutt opened this issue Jul 23, 2019 · 6 comments

Comments

@willtebbutt
Copy link
Collaborator

Would be very helpful to have efficient implementations for cholesky, eigen, etc for Kronecker-product matrices (I believe these have efficient representations).

(Nice talk btw)

@MichielStock
Copy link
Owner

A function for cholesky and related support is now added in a new module. CholeskyKronecker is part of my type system, but should behave similarly to Cholesky of the LinearAlgebra module.

Work in progress!

@willtebbutt
Copy link
Collaborator Author

Update: eigen was resolved by #16. Just leaves implementing the cholesky in a similar manner.

@MichielStock
Copy link
Owner

Hmmm, was looking to do cholesky the same way, but this seems to be more challenging:

https://github.com/JuliaLang/julia/blob/36c59c144122dbf09fc0e1f0f1e9defbbd2f254d/stdlib/LinearAlgebra/src/cholesky.jl#L72-L81

The current implementation has its own type within Kronecker.jl type system. I don't see how elso to do this?

@willtebbutt
Copy link
Collaborator Author

I had a working prototype a while ago i think. Will dig it out and try to finish it off + make a PR in the next few days.

@MichielStock
Copy link
Owner

If you post it, I can do it?

@willtebbutt
Copy link
Collaborator Author

Required a bit of work to get anything off the ground, so make #44 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants