Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax kroneckersum test #133

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Relax kroneckersum test #133

merged 1 commit into from
Nov 16, 2023

Conversation

dkarrasch
Copy link
Contributor

This came up in a pkgeval run in JuliaLang/julia#52038. I don't think exact equality can be expected here with floating point numbers, so I propose to relax this test. Another option could be to use integer matrices upfront.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dd1439c) 91.42% compared to head (2656a5f) 91.42%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files          11       11           
  Lines         840      840           
=======================================
  Hits          768      768           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichielStock
Copy link
Owner

Agreed!

@MichielStock MichielStock merged commit 096ab9a into MichielStock:master Nov 16, 2023
8 of 12 checks passed
@dkarrasch dkarrasch deleted the patch-2 branch November 19, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants