-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request: Add title to cleanup routine. #32
Comments
Not without changes in Kodi. You see, the If the The only reliable solution for this problem would for |
well I changed the code in 2.1.7 to test if my changes did something but no, those chnages would be overridden by 2.1.7 -> 2.1.8 update anyway or no? Is this something you can request from team? IF not doesn't matter, its just useless output for humans to look at and I suppose if addons and web interfaces also do that then they get no better human readable output. |
It should have been overwritten, yes... I've looked at the 2.1.8 code on master and don't see how
Ping @anaconda / @Montellese
Hey I like it. :) I understand your point though, but I feel I need to output some sort of progress, even if it's just an |
Thinking about this a bit more, and looking at what the current code does, it's actually more than just retrieving It's probably not practical for all of these fields to be added to the |
see the PR up |
This isn't super-easy. |
I'm pretty sure there was a time when the Based on your analysis (many thanks) it would seem a relatively recent refactor has now ensured that the I'll probably drop the attempt to obtain the I agree that moving the Although the problem is that to do it properly, when an episode is deleted you'd really need to include the title of the tvshow, plus title of the episode and ideally season # and episode # as fields in the |
I can't read. |
The idea of notifications is that they are as small as possible so that it doesn't put any unnecessary limitations on the receivers. So expanding the |
I thought I could nail this but I cant.
getting none or just episode id is not really human readable friendly stuff, I tried adding the title part and failed, clearly its above my paygrade.
Can this be added?
The text was updated successfully, but these errors were encountered: