Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web version broken when updating wasm-bindgen to 0.2.85 #14265

Closed
dannywillems opened this issue Oct 4, 2023 · 8 comments
Closed

Web version broken when updating wasm-bindgen to 0.2.85 #14265

dannywillems opened this issue Oct 4, 2023 · 8 comments
Assignees

Comments

@dannywillems
Copy link
Member


  1) [chromium-desktop] › on-chain-state-mgmt-zkapp-ui.spec.ts:4:3 › On-Chain State Management zkApp UI › should load page and initialize SnarkyJS 

    Error: expect(received).toContainText(expected)

    Expected string: "SnarkyJS initialized after"
    Received string: "No data available yet."
    Call log:

See o1-labs/o1js#1160, while fixing #14253

@dannywillems dannywillems self-assigned this Oct 4, 2023
@dannywillems
Copy link
Member Author

Maybe related to the web worker?

@dannywillems
Copy link
Member Author

Oh wait, there are some .ptr used in web-backend.js...

@dannywillems
Copy link
Member Author

There is also rustwasm/wasm-bindgen@46ea32f

@dannywillems
Copy link
Member Author

While running locally, getting in the console:

index.js:11398 Uncaught ReferenceError: init is not defined
    at plonkWasm (index.js:11398:14)
    at index.js:13812:12

@dannywillems
Copy link
Member Author

Also this: rustwasm/wasm-bindgen@76e4cad

@dannywillems
Copy link
Member Author

We must change:

  • getImports into __wbg_get_imports
  • finalizeInit into __wbg_finalize_init
  • init into __wbg_init
  • load into __wbg_load
  • initMemory into __wbg_init_memory

@joseandro
Copy link
Contributor

@nicc and @garwalsh is it OK to assign this task to your team?

@mitschabaude
Copy link
Contributor

done and merged ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants