From a458d12d44e6c5c42fe5c09ce1eb2b2716f3d03c Mon Sep 17 00:00:00 2001 From: Gregor Date: Fri, 3 Nov 2023 10:15:37 +0100 Subject: [PATCH] uncover bug by using more realistic configs in custom gates test --- .../pickles_test_optional_custom_gates.ml | 20 +++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/src/lib/pickles/test/optional_custom_gates/pickles_test_optional_custom_gates.ml b/src/lib/pickles/test/optional_custom_gates/pickles_test_optional_custom_gates.ml index 8456e1d1c1e..4d3578e9dfd 100644 --- a/src/lib/pickles/test/optional_custom_gates/pickles_test_optional_custom_gates.ml +++ b/src/lib/pickles/test/optional_custom_gates/pickles_test_optional_custom_gates.ml @@ -378,16 +378,28 @@ let register_feature_test (name, specific_feature_flags) = let () = let configurations = - [ ("xor", Plonk_types.Features.{ none_bool with xor = true }) + [ ( "xor" + , Plonk_types.Features.{ none_bool with xor = true; range_check0 = true } + ) ; ( "range check 0" , Plonk_types.Features.{ none_bool with range_check0 = true } ) ; ( "range check 1" , Plonk_types.Features.{ none_bool with range_check1 = true } ) ; ("rot", Plonk_types.Features.{ none_bool with rot = true }) ; ( "foreign field addition" - , Plonk_types.Features.{ none_bool with foreign_field_add = true } ) - ; ( "foreign field multiplication" - , Plonk_types.Features.{ none_bool with foreign_field_mul = true } ) + , Plonk_types.Features. + { none_bool with + foreign_field_add = true + ; range_check0 = true + ; range_check1 = true + } ) + ; ( "foreign field multiplication" (* FIXME: this configuration fails *) + , Plonk_types.Features. + { none_bool with + foreign_field_mul = true + ; (* toggling this to `false` makes the test succeed *) + range_check0 = true + } ) ; ( "Fixed lookup tables" , Plonk_types.Features.{ none_bool with lookup = true } ) ]