Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize lack of redistribution in some denudation models #50

Closed
jhidding opened this issue Sep 5, 2024 · 4 comments · Fixed by #62
Closed

optimize lack of redistribution in some denudation models #50

jhidding opened this issue Sep 5, 2024 · 4 comments · Fixed by #62
Assignees

Comments

@jhidding
Copy link
Member

jhidding commented Sep 5, 2024

the redistribution function now returns zero arrays which is a waste of energy.

possible solutions:

  • return nothing instead, and deal with those in the model code
  • redesign so that redistribution is never called on these models
@xyl96 xyl96 self-assigned this Sep 25, 2024
@xyl96
Copy link
Contributor

xyl96 commented Sep 28, 2024

Have done this. Do I need to add a test for this and make sure when it encounters nothing it's indeed not assigning space for nothing?

@jhidding
Copy link
Member Author

Let's look at that tomorrow. I'll be in the office.

@jhidding
Copy link
Member Author

jhidding commented Sep 29, 2024

Btw, I can't see your solution. Could you create a branch and PR? You can use the button 'develop' here on the right.

No matter, found it!

@xyl96
Copy link
Contributor

xyl96 commented Sep 29, 2024

Btw, I can't see your solution. Could you create a branch and PR? You can use the button 'develop' here on the right.

No matter, found it!

I created a branch called issue/50, should I PR rn?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants