-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The process of molecular production is too slow. #20
Comments
Hi, |
Dear author, I find it difficult for me to get corresponding 3D results from the generated SMILES files(.pkl files). The ReadMe file you provided mentioned that it seems that the SMILES file needs to use the sampling function in the training file, but I find this difficult to achieve. Is there any function file or advices for visualization that you can provide?
Thank you for your help.
…---- Replied Message ----
| From | Minkai ***@***.***> |
| Date | 04/5/2023 10:35 |
| To | ***@***.***> |
| Cc | ***@***.***> ,
***@***.***> |
| Subject | Re: [MinkaiXu/GeoDiff] The process of molecular production is too slow. (Issue #20) |
Hi,
Sorry for the late reply. I think this is unnormal, where a single step takes 12-24s. I suppose GPU might not be correctly activated?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Dear author, I also find it difficult for me to get corresponding 3D results from the generated SMILES files(.pkl files). The ReadMe file you provided mentioned that it seems that the SMILES file needs to use the sampling function in the training file, but I find this difficult to achieve. Is there any function file or advice for visualization that you can provide? Thank you for your help |
Hi, For visualization, we just use the software called PyMol, which can render molecular structures. Thanks! |
But the pymol seems to be unable to handle binary files like pkl. Maybe I didn't notice other handler functions? Let me confirm that you only need to use PYMOL to visualize the pkl file generated from the test file as the corresponding 3D structure, right? Thank you very much for your patient answer~~ |
Oh, not exactly the same as the test file. The molecules are stored as some tensors in the generated test file, while you need to reformat them (or a few of the interested ones) to rdkit.mol format. |
OK!Thank you very much for your detailed reply! Do I need to use the sampling function in the model? I refer to the solution in this issue (DeepGraphLearning/ConfGF#1) to realize the conversion of pkl files to sdf files, but I found that this requires the use of sampling functions. It seems that it is not easy to directly convert the pkl file to rdkit.mol format and then open it directly with pymol. |
If you just want to do visualization (of data in the test set), this should be unnecessary. |
I want to visualize the molecules generated by your Geodiff. Of course, the visualization of the molecules in the test set is also needed~ |
Sorry, there is a typo in my previous message (necessary->unnecessary)... Just load both and take a look --- there should be You can take a closer look at all the .pkl files. You can also look at the sampling code to better understand what we saved for generated mols. Sorry that it's also hard for me to remember all the engineering details... |
Thanks again for your patient reply! I will try this solution and update my solution in time. |
@MinkaiXu how much time each step should take? @JackAILab how did you resolve the slow computation? |
The process of molecular production is too slow. It takes about 2-4 hours to form a molecule. As shown in the figure, 5,000 time steps are the diffusion process of a molecule. One step actually takes about 12s-24s, which means that the formation of a molecule takes 2-4 hours. Is there any way to improve it? Or is there a failure of my server? How long does it take you to generate molecules?
Looking forward to and thank you for your reply!
The text was updated successfully, but these errors were encountered: