Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection Box Overlaps Boxart #2

Open
ClaireSoftware opened this issue Dec 30, 2019 · 1 comment
Open

Selection Box Overlaps Boxart #2

ClaireSoftware opened this issue Dec 30, 2019 · 1 comment
Labels
to-do Planned on the list for the future

Comments

@ClaireSoftware
Copy link

Hello! I was recently working on a custom theme with boxart for my games, but I noticed the selection bar in selector.cpp spans the whole width of the screen (it's bound to listRect.w, which is in turn bound to the screen resolution. If boxart is enabled, this causes the selection box to overlap the boxart picture. To remedy this, another configuration option could be created to override this, perhaps selBarWidth or similar, and have the width of the box default to listRect.w if such an option isn't found.

https://github.com/MiyooCFW/gmenunx/blob/b2ca041a4e2e613bb8b0c61b0879fac6a0afb94e/src/selector.cpp#L111

@ericrkjones
Copy link
Contributor

I think the question we need to answer is whether the preview pane is supposed to be displayed over the selection pane with partial transparency (currently) or next to it so that the text does not lay behind the box.

Given that the boxart is animated to slide in from the right (more apparent in the "Explorer" program, in the selector the animation is so fast that it basically isn't used), I understood the intent to be that the preview pane should overlay the selector pane.

@Apaczer Apaczer added the to-do Planned on the list for the future label Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-do Planned on the list for the future
Projects
None yet
Development

No branches or pull requests

3 participants