Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should make it harder to delete menu entries and sections (or easier to undo) #4

Open
nfriedly opened this issue Sep 1, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@nfriedly
Copy link
Member

nfriedly commented Sep 1, 2021

I've accidentally deleted things in Gmenunx, and other people keep asking where all of their menu entries went on reddit, e.g. https://www.reddit.com/r/SBCGaming/comments/pfo637/why_isnt_the_emulators_icon_not_showing_or/

I have a couple of ideas for how to make this better:

  • We could just hide the entries instead of deleting them. Maybe prefix with a . and then ensure that Gmenunx ignores dotfiles. (It might already, I haven't checked yet.)
    • And then add a way to unhide individual entries, or maybe just a single "unhide everything" option
  • Allow recent changes to be undone
  • Make separate modes for editing the menu vs just using the device. In the regular usage mode, you can't delete or edit menu entries, and in the editing mode you can't launch games. It'd have to be pretty simple to get out of the editing mode, though - maybe just press B to exit or something.
  • Don't allow deleting menu sections with links still in them (require that the user delete all of the links in the section first if they really want to delete it)
  • Require two buttons pressed simultaneously, maybe A+Y to confirm deletion of things

I don't know what the best answer is, and some of those could be combined, but I just feel like it's too easy to accidentally delete entire menu sections right now.

I might work on this sometime soon.

(Obviously any improvements here could be up-streamed to other Gmenunx / Gmenu2x repositories, but I'm using Miyoo, so this is where I'd start.)

@TriForceX TriForceX added the enhancement New feature or request label Sep 1, 2021
@TriForceX
Copy link
Member

i marked this as an improvement to be included in the next release.

Yea is a common problem in terms of "user experience" and needs to be improved.

@nfriedly
Copy link
Member Author

nfriedly commented Sep 1, 2021

Here's one idea that expands on the "hiding" one. Give each menu entry a show/hide setting with a few possibilities:

  • Show
  • Hide
  • Show if Games - this one would check the games directory and show only if there are files in it. This could be the default for all of the emulators so that ones without any roms would be hidden by default. It could optionally know about the supported file extensions, so that, for example, a .txt file with instructions wouldn't cause the emulator to be shown.
  • If necessary, some variation of "Show if Games" that works for ports that need additional files to be playable

Then completely get rid of the ability to delete menu entries from gmenunx - make that menu just toggle show/hide instead.

And, then, finally, add a global menu option for "show hidden menu entries" (off by default), so that users could turn it on to go back and show something they hid by accident.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants