Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some GMenu2X messages are missing from the translation file #43

Open
MayanKoyote opened this issue Nov 23, 2023 · 12 comments
Open

Some GMenu2X messages are missing from the translation file #43

MayanKoyote opened this issue Nov 23, 2023 · 12 comments
Labels
to-do Planned on the list for the future

Comments

@MayanKoyote
Copy link
Contributor

MayanKoyote commented Nov 23, 2023

While I was playing with the settings, checking that the translation parts matched each other and stuff, I noticed several untranslated (not translatable) messages:

  1. Time settings screen called up by long pressing on "X" button - these are the lines "SW Clock" and "Set system's software clock":
    s001

  2. Message "This directory is empty" when launching selector browser if the assigned directory is empty and changing directories is not allowed:
    s002

  3. Message "Add to Favorites" in the selector browser on any of the files inside the assigned directory:
    s003

  4. The message itself "Screenshot saved" when pressing "SELECT" + "START" buttons. (I can't take a screenshot of this message)

If to add these lines (and their translation) to the translation file by yourself, the translation appears.
Since they are not difficult to reach while going through the settings, it would be nice to add them to the translate.txt file permanently.

@Apaczer
Copy link
Member

Apaczer commented Nov 23, 2023

Thanks, the following entries will be added:

CHEATER! ;)=
SW Clock=
Set system's software clock=
This directory is empty=
Add to Favourites=
Screenshot saved=

If you find anything more, please let me know!

While quickly testing I found also that some things can't be translated with current code:

  • string values in settings and skin menu
  • boolean OFF/ON (in settings/edit menus)
  • multstring OFF/ON/AUTO
  • section names in editLink menu are not translated
  • apps titles and description in editLink menu (these are not include in translate.txt)

Until I fix above I'll post pone any changes for now.

@Apaczer
Copy link
Member

Apaczer commented Nov 27, 2023

it would be nice to add them to the translate.txt file permanently.

@MayanKoyote - they have been added, but let us keep this issue open for ppl to know about mentioned translation issues.

@MayanKoyote
Copy link
Contributor Author

MayanKoyote commented Dec 10, 2023

Since things have gone well with favourites, it would be nice to add line:
Link created=
This is the message that appears when you add something to your favourites.
Manual addition shows that it's translatable.

And also the remaining viewers:
viewers
so strings from dictionary.txt are:
Image viewer=
Pan=
Text viewer=
Zip content=

@Apaczer
Copy link
Member

Apaczer commented Dec 11, 2023

Indeed, thanks I can see it in dictionary.txt. There is still small issue with text wraping which I'm investigating (will add missing string after fix).

"ярлык создано"?

@MayanKoyote
Copy link
Contributor Author

Ярлык создан

@MayanKoyote
Copy link
Contributor Author

MayanKoyote commented Dec 12, 2023

Caught another missing string.
Power Menu -> 'R' button to Reboot -> message "Rebooting".
Message is not translated.
Since this is a message, I can't take a screenshot of it. It will be screenshotless.
so string from dictionary.txt is:
Rebooting=

@MayanKoyote
Copy link
Contributor Author

MayanKoyote commented Dec 12, 2023

Next will be the 'Autostart - Run last app on restart' feature.
When you enable this feature, you get this dialog after a reboot:
IMG_AST1

so strings from dictionary.txt are:
Continue with the AutoStart selected app?=
Remove this dialog!=

@Apaczer
Copy link
Member

Apaczer commented Dec 15, 2023

Updated FontHelper, still not ideal but there shouldn't be now weird text wrapping. Added missing strings, thanks again!

@MayanKoyote
Copy link
Contributor Author

MayanKoyote commented Dec 16, 2023

I will continue with the "viewers".

The window that appears when launching files with the .sh extension in Explorer:
TERM
Terminal=

  • Translating the string "Terminal=" also translates the name of the 'Terminal' application displayed on the menu screen in the application section. But I couldn't find where to translate its description (ST Terminal Emulator) that appears at the bottom of the screen. I understand that this is a separate application, but since the name has already been translated and it is included in the basic package, it would be nice to see its description to be translatable too:
    STTE
    UPDATE: Indeed, translating the shortcut names turned out to be quite simple. For example, I just added 'Commander=Коммандер' to the translation file and now 'Commander' is called 'Коммандер' on Apps screen. Apparently this feature is somehow provided for names, but not for descriptions.

The skin 'package' installation window that appears when Explorer processes a file with a names like gmenu2x-skin-xxx.zip or gmenunx-skin-xxx.zip:
THMI
Skin installer=
Installing skin=

The window title that appears when deleting a previously installed .ipk package (not just a shortcut):
IPKU
Uninstall package=

And the strings that are common to these/such windows:
Running.. Please wait..=
Done=

  • The 'Done' message likes to be superimposed on top of existing output lines, which adds even more clutter to the output. This can be seen from some of the screenshots above (Zip content, Skin installer).

Probably quite a few strings (~9 strings) regarding the processing of .opk packages could also fit here. But since the Explorer does not want to process .opk packages (yet), it is too early to translate them (yet).

@Apaczer Apaczer added the to-do Planned on the list for the future label Dec 17, 2023
@Apaczer
Copy link
Member

Apaczer commented Dec 17, 2023

The apps are not a part of GMenu2X build (exceptions are cores, emus, games sections translation), so I've wanted to keep them separate. I've plans to embend them in current code as ActionLink (see for e.g. Explorer) that way these links will be part of gmenu2x binary itself.
For some sanity, I've changed Terminal app name to Simple Terminal (in apps section) as it more accurently descripte it and doesn't collide with gmenu2x's terminal naming.

Fixed "iconDescription" translating with: aa398ec Tks for noticing!

Instead of impossing "Done" string over text output, now it just displays msgbox with "Done processing." 🙏

@MayanKoyote
Copy link
Contributor Author

I compared the files dictionary.txt and translate.txt, removed matches and looked at the conditions for the appearance of the remaining string.
And managed to identify another (and perhaps the last one) translatable but previously unnoticed string:
Selector Path=
The window containing it can be called through the shortcut settings: Edit link -> File Selector -> press 'A'.
selpath


The rest strings either relate to other non-Miyoo platforms (like TARGET_GP2X/WIZ/CAANOO or gp2x.h/retrofw.h),
or to cases when flags that are not used for Miyoo compilation are defined (HW_EXT_SD/HW_GAMMA/HW_SCALER/HW_TVOUT/HW_UDC/NO_REBOOT/OPK_SUPPORT).
Also there are 2 cases, the conditions for the possibility of appearing on the screen I could not understand/find:
https://github.com/MiyooCFW/gmenu2x/blob/e22ca905b31193c003a4da04968d604cc2d045a1/src/wallpaperdialog.cpp#L87C3-L92C4
https://github.com/MiyooCFW/gmenu2x/blob/ccfa8a68ee1be24d91b76647ccf27c8c13def77f/src/gmenu2x.cpp#L1631C1-L1637C3


So considering all this, it is quite possible that this is all for now.

@Apaczer
Copy link
Member

Apaczer commented Dec 23, 2023

Good findings, I spent some time to strip whole code of unnecessary code blocks and grabed all tr[".."] occurences. This make final translate.txt for MiyooCFW with: 33d9fdd
Most of new findings are unused in real scanario like you mentioned for .e.g

  • "GMenu2X will restart to apply" never occurs because void reinit(false) is executed every time (this msgbox is kinda broken currently but will have to see if I can make use of it).
  • "No wallpapers available" GMenu2X can't handel empty string "wallpaper" at ccfa8a6#L603 that's it will crash and loop endlesly in MiyooCFW. Even so there is no proper logic to SDL_FillRect with 0,0,0 color where there is no wallpaper.jpg file to SDL_BlitSurface over current window, as a result it will leave on background whatever has been redraw. Might have a look at it someday. You know that already
  • "Directory to start the selector=" and a few others descriptions from BrowseDialog() never occur because there's no place where they could be displayed (unusable currently - to implement)
  • "Umount" etc. is for /media storage devices which are yet to be added to MiyooCFW

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
to-do Planned on the list for the future
Projects
None yet
Development

No branches or pull requests

2 participants