Skip to content

Commit a0ded38

Browse files
committed
[DOP-23620] Fix scheduler not closing DB connections
1 parent 7035490 commit a0ded38

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

syncmaster/scheduler/transfer_fetcher.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
from syncmaster.db.models import Transfer
66
from syncmaster.scheduler.settings import SchedulerAppSettings as Settings
7-
from syncmaster.scheduler.utils import get_async_session
7+
from syncmaster.scheduler.utils import get_async_engine, get_async_session
88

99

1010
class TransferFetcher:
@@ -13,8 +13,7 @@ def __init__(self, settings: Settings):
1313
self.last_updated_at = None
1414

1515
async def fetch_updated_jobs(self) -> list[Transfer]:
16-
17-
async with get_async_session(self.settings) as session:
16+
async with get_async_engine(self.settings) as engine, get_async_session(engine) as session:
1817
query = select(Transfer)
1918
if self.last_updated_at is not None:
2019
query = query.filter(Transfer.updated_at > self.last_updated_at)

syncmaster/scheduler/transfer_job_manager.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,9 @@ def update_jobs(self, transfers: list[Transfer]) -> None:
5151

5252
async def remove_orphan_jobs(self) -> None:
5353
all_jobs = self.scheduler.get_jobs()
54-
settings = self.settings
5554
job_transfer_ids = [int(job.id) for job in all_jobs]
5655

57-
async with get_async_engine(settings) as engine, get_async_session(engine) as session:
56+
async with get_async_engine(self.settings) as engine, get_async_session(engine) as session:
5857
result = await session.execute(
5958
select(Transfer).where(Transfer.id == any_(job_transfer_ids)), # type: ignore[arg-type]
6059
)

0 commit comments

Comments
 (0)