Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update column names to be more informative #33

Open
jchodera opened this issue Feb 17, 2017 · 2 comments
Open

Update column names to be more informative #33

jchodera opened this issue Feb 17, 2017 · 2 comments

Comments

@jchodera
Copy link
Contributor

Now that we're distributing FreeSolv in multiple forms (SDF files, Orion datasets), it would be useful if the column names (that become SD tags) were more informative and self-documenting about things like units. For example, the "expt" label is problematic since (1) it doesn't describe which of the many properties this is the experimental value for, and (2) it doesn't give the units. More informative names would very much help!

@davidlmobley
Copy link
Member

Agreed! What's your favorite way to attach units now? simtk.unit, or have you migrated towards something else?

Though, there's also the issue of how things will pickle or go to JSON which I've not thought through yet. Perhaps we should just embed units in the name of the key or tag.

@jchodera
Copy link
Contributor Author

We're still using simtk.unit for Python, which can also render units in a human-readable form.

@bas-rustenburg has used pint, which is very similar and independent of OpenMM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants